Sign upLogin

xoopscube/altsys

View on GitHub
Star
xoops_trust_path/libs/altsys/oninstall.php

Summary

Maintainability
D
2 days
Test Coverage

Function altsys_oninstall_base has a Cognitive Complexity of 63 (exceeds 5 allowed). Consider refactoring.
Open

        function altsys_oninstall_base( $module, $mydirname ) {
            // transactions on module install

            global $ret; // TODO :-D
Severity: Minor
Found in xoops_trust_path/libs/altsys/oninstall.php - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method altsys_oninstall_base has 80 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        function altsys_oninstall_base( $module, $mydirname ) {
            // transactions on module install

            global $ret; // TODO :-D
Severity: Major
Found in xoops_trust_path/libs/altsys/oninstall.php - About 3 hrs to fix

    Avoid deeply nested control flow statements.
    Open

                        if ( is_file( $file_path ) ) {
                        $mtime   = (int) @filemtime( $file_path );
                        $tplfile = $tplfile_handler->create();
                        $tplfile->setVar( 'tpl_source', file_get_contents( $file_path ), true );
                        $tplfile->setVar( 'tpl_refid', $mid );
    Severity: Major
    Found in xoops_trust_path/libs/altsys/oninstall.php - About 45 mins to fix

      Avoid deeply nested control flow statements.
      Open

                          if ( '.' == substr( $file, 0, 1 ) ) {
                        continue;
                    }
      Severity: Major
      Found in xoops_trust_path/libs/altsys/oninstall.php - About 45 mins to fix

        Function altsys_message_append_oninstall has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

                function altsys_message_append_oninstall( &$module_obj, &$log ) {
            if ( is_array( @$GLOBALS['ret'] ) ) {
                foreach ( $GLOBALS['ret'] as $message ) {
                    $log->add( strip_tags( $message ) );
                }
        Severity: Minor
        Found in xoops_trust_path/libs/altsys/oninstall.php - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                                if ( ! $tplfile_handler->insert( $tplfile ) ) {
                            $ret[] = '<span style="color:#ff0000;">ERROR: Could not insert template <b>' . htmlspecialchars( $mydirname . '_' . $file ) . '</b> to the database.</span><br>';
                        } else {
                            $tplid = $tplfile->getVar( 'tpl_id' );
                            $ret[] = 'Template <b>' . htmlspecialchars( $mydirname . '_' . $file ) . '</b> added to the database. (ID: <b>' . $tplid . '</b>)<br>';
        Severity: Major
        Found in xoops_trust_path/libs/altsys/oninstall.php and 1 other location - About 1 hr to fix
        xoops_trust_path/libs/altsys/onupdate.php on lines 71..79

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 120.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status