Sign upLogin

yahoo/kobold-core

View on GitHub
Star

Showing 7 of 36 total issues

KeyValueStorageAdapter has 27 functions (exceeds 20 allowed). Consider refactoring.
Open

    {
        /**
         * Initializes the source-adapter
         *
         * @method initialize
Severity: Minor
Found in lib/storageAdapter/keyValueStorageAdapter.js - About 3 hrs to fix

FileStorageAdapter has 27 functions (exceeds 20 allowed). Consider refactoring.
Open

    {
        /**
         * Initializes the source-adapter
         *
         * @method initialize
Severity: Minor
Found in lib/storageAdapter/fileStorageAdapter.js - About 3 hrs to fix

Function run has 59 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        run : function () {
            return new Promise(function (resolve, reject) {

                var imageA = this.getImageA(),
                    pathA,
Severity: Major
Found in lib/comparisonAdapter/shellAdapter.js - About 2 hrs to fix

Function _prepareBucket has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

        _prepareBucket: function (bucketName, key, initialValue, failWhenExist) {

            return this.getPromise().then(function () {

                return this._connection.hasBucket(bucketName).then(function (hasBucket) {
Severity: Minor
Found in lib/storageAdapter/keyValueStorageAdapter.js - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function run has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

        run : function () {
            return new Promise(function (resolve, reject) {

                var imageA = this.getImageA(),
                    pathA,
Severity: Minor
Found in lib/comparisonAdapter/shellAdapter.js - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function _evaluateResult has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

        _evaluateResult: function (err, result, diff, resolve, reject) {
Severity: Minor
Found in lib/comparisonAdapter/perceptualDiffAdapter.js - About 35 mins to fix

Function _evaluateResult has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

        _evaluateResult: function (err, result, blinkDiff, resolve, reject) {
Severity: Minor
Found in lib/comparisonAdapter/blinkDiffAdapter.js - About 35 mins to fix
Severity
Category
Status
Source
Language