yannickcr/eslint-plugin-react

View on GitHub
lib/rules/no-set-state.js

Summary

Maintainability
C
7 hrs
Test Coverage

Function create has 38 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  create: Components.detect((context, components, utils) => {
    /**
     * Checks if the component is valid
     * @param {Object} component The component to process
     * @returns {Boolean} True if the component is valid, false if not.
Severity: Minor
Found in lib/rules/no-set-state.js - About 1 hr to fix

    Function create has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

      create: Components.detect((context, components, utils) => {
        /**
         * Checks if the component is valid
         * @param {Object} component The component to process
         * @returns {Boolean} True if the component is valid, false if not.
    Severity: Minor
    Found in lib/rules/no-set-state.js - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        function reportSetStateUsages(component) {
          let setStateUsage;
          for (let i = 0, j = component.setStateUsages.length; i < j; i++) {
            setStateUsage = component.setStateUsages[i];
            report(context, messages.noSetState, 'noSetState', {
    Severity: Major
    Found in lib/rules/no-set-state.js and 1 other location - About 2 hrs to fix
    lib/rules/no-direct-mutation-state.js on lines 50..58

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 80.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

          'Program:exit'() {
            values(components.list())
              .filter((component) => !isValid(component))
              .forEach((component) => {
                reportSetStateUsages(component);
    Severity: Major
    Found in lib/rules/no-set-state.js and 1 other location - About 1 hr to fix
    lib/rules/no-direct-mutation-state.js on lines 145..151

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 61.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

            if (
              callee.type !== 'MemberExpression'
              || callee.object.type !== 'ThisExpression'
              || callee.property.name !== 'setState'
            ) {
    Severity: Minor
    Found in lib/rules/no-set-state.js and 1 other location - About 40 mins to fix
    lib/util/makeNoMethodSetStateRule.js on lines 89..95

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 48.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 17 locations. Consider refactoring.
    Open

      meta: {
        docs: {
          description: 'Disallow usage of setState',
          category: 'Stylistic Issues',
          recommended: false,
    Severity: Major
    Found in lib/rules/no-set-state.js and 16 other locations - About 35 mins to fix
    lib/rules/jsx-no-comment-textnodes.js on lines 37..48
    lib/rules/no-array-index-key.js on lines 45..56
    lib/rules/no-danger.js on lines 47..58
    lib/rules/no-deprecated.js on lines 118..129
    lib/rules/no-find-dom-node.js on lines 20..31
    lib/rules/no-is-mounted.js on lines 20..31
    lib/rules/no-namespace.js on lines 22..33
    lib/rules/no-redundant-should-component-update.js on lines 21..32
    lib/rules/no-render-return-value.js on lines 21..32
    lib/rules/no-this-in-sfc.js on lines 20..31
    lib/rules/no-typos.js on lines 32..43
    lib/rules/no-unused-class-component-methods.js on lines 102..111
    lib/rules/no-unused-state.js on lines 81..92
    lib/rules/prefer-exact-props.js on lines 24..33
    lib/rules/react-in-jsx-scope.js on lines 22..33
    lib/rules/require-render-return.js on lines 25..36

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 47.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status