Sign upLogin

yannickcr/eslint-plugin-react

View on GitHub
Star
lib/rules/no-unstable-nested-components.js

Summary

Maintainability
D
2 days
Test Coverage

Function create has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
Open

  create: Components.detect((context, components, utils) => {
    const allowAsProps = context.options.some((option) => option && option.allowAsProps);

    /**
     * Check whether given node is declared inside class component's render block
Severity: Minor
Found in lib/rules/no-unstable-nested-components.js - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function create has 98 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  create: Components.detect((context, components, utils) => {
    const allowAsProps = context.options.some((option) => option && option.allowAsProps);

    /**
     * Check whether given node is declared inside class component's render block
Severity: Major
Found in lib/rules/no-unstable-nested-components.js - About 3 hrs to fix

    File no-unstable-nested-components.js has 255 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    /**
 * @fileoverview Prevent creating unstable components inside components
 * @author Ari Perkkiö
 */
    Severity: Minor
    Found in lib/rules/no-unstable-nested-components.js - About 2 hrs to fix

      Consider simplifying this complex logical expression.
      Open

            if (
        // Support allowAsProps option
        (isDeclaredInsideProps && (allowAsProps || isComponentInRenderProp(node, context)))

        // Prevent reporting components created inside Array.map calls
      Severity: Critical
      Found in lib/rules/no-unstable-nested-components.js - About 1 hr to fix

        Function validate has 39 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            function validate(node) {
      if (!node || !node.parent) {
        return;
      }
        Severity: Minor
        Found in lib/rules/no-unstable-nested-components.js - About 1 hr to fix

          Function isComponentInRenderProp has 35 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          function isComponentInRenderProp(node, context) {
  if (
    node
    && node.parent
    && node.parent.type === 'Property'
          Severity: Minor
          Found in lib/rules/no-unstable-nested-components.js - About 1 hr to fix

            Function isComponentInRenderProp has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

            function isComponentInRenderProp(node, context) {
  if (
    node
    && node.parent
    && node.parent.type === 'Property'
            Severity: Minor
            Found in lib/rules/no-unstable-nested-components.js - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Avoid too many return statements within this function.
            Open

              return false;
            Severity: Major
            Found in lib/rules/no-unstable-nested-components.js - About 30 mins to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                if (
    node
    && node.parent
    && node.parent.type === 'JSXExpressionContainer'
    && node.parent.parent
              Severity: Major
              Found in lib/rules/no-unstable-nested-components.js and 1 other location - About 1 hr to fix
              lib/rules/no-unstable-nested-components.js on lines 195..213

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 58.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                if (
    jsxExpressionContainer
    && jsxExpressionContainer.parent
    && jsxExpressionContainer.parent.type === 'JSXAttribute'
    && jsxExpressionContainer.parent.name
              Severity: Major
              Found in lib/rules/no-unstable-nested-components.js and 1 other location - About 1 hr to fix
              lib/rules/no-unstable-nested-components.js on lines 182..190

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 58.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status