Sign upLogin

yashketkar/video-player

View on GitHub
Star
vitamio/src/io/vov/vitamio/provider/MediaStore.java

Summary

Maintainability
D
1 day
Test Coverage

Method getThumbnail has a Cognitive Complexity of 40 (exceeds 5 allowed). Consider refactoring.
Open

    static Bitmap getThumbnail(Context ctx, ContentResolver cr, long origId, long groupId, int kind, BitmapFactory.Options options, Uri baseUri) {
      Bitmap bitmap = null;
      MiniThumbFile thumbFile = MiniThumbFile.instance(baseUri);
      long magic = thumbFile.getMagic(origId);
      if (magic != 0) {
Severity: Minor
Found in vitamio/src/io/vov/vitamio/provider/MediaStore.java - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File MediaStore.java has 272 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/*
 * Copyright (C) 2006 The Android Open Source Project
 * Copyright (C) 2013 YIXIA.COM
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
Severity: Minor
Found in vitamio/src/io/vov/vitamio/provider/MediaStore.java - About 2 hrs to fix

    Method getThumbnail has 60 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        static Bitmap getThumbnail(Context ctx, ContentResolver cr, long origId, long groupId, int kind, BitmapFactory.Options options, Uri baseUri) {
      Bitmap bitmap = null;
      MiniThumbFile thumbFile = MiniThumbFile.instance(baseUri);
      long magic = thumbFile.getMagic(origId);
      if (magic != 0) {
    Severity: Major
    Found in vitamio/src/io/vov/vitamio/provider/MediaStore.java - About 2 hrs to fix

      Method getThumbnail has 7 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          static Bitmap getThumbnail(Context ctx, ContentResolver cr, long origId, long groupId, int kind, BitmapFactory.Options options, Uri baseUri) {
      Severity: Major
      Found in vitamio/src/io/vov/vitamio/provider/MediaStore.java - About 50 mins to fix

        Method getThumbnail has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

              public static Bitmap getThumbnail(Context ctx, ContentResolver cr, long origId, long groupId, int kind, BitmapFactory.Options options) {
        Severity: Minor
        Found in vitamio/src/io/vov/vitamio/provider/MediaStore.java - About 45 mins to fix

          Method getThumbnail has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

                public static Bitmap getThumbnail(Context ctx, ContentResolver cr, long origId, int kind, BitmapFactory.Options options) {
          Severity: Minor
          Found in vitamio/src/io/vov/vitamio/provider/MediaStore.java - About 35 mins to fix

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                      synchronized (sThumbBufLock) {
            if (sThumbBuf == null)
              sThumbBuf = new byte[MiniThumbFile.BYTES_PER_MINTHUMB];
            if (thumbFile.getMiniThumbFromFile(origId, sThumbBuf) != null) {
              bitmap = BitmapFactory.decodeByteArray(sThumbBuf, 0, sThumbBuf.length);
            Severity: Major
            Found in vitamio/src/io/vov/vitamio/provider/MediaStore.java and 1 other location - About 1 hr to fix
            vitamio/src/io/vov/vitamio/provider/MediaStore.java on lines 291..299

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 78.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                      synchronized (sThumbBufLock) {
            if (sThumbBuf == null)
              sThumbBuf = new byte[MiniThumbFile.BYTES_PER_MINTHUMB];
            if (thumbFile.getMiniThumbFromFile(origId, sThumbBuf) != null) {
              bitmap = BitmapFactory.decodeByteArray(sThumbBuf, 0, sThumbBuf.length);
            Severity: Major
            Found in vitamio/src/io/vov/vitamio/provider/MediaStore.java and 1 other location - About 1 hr to fix
            vitamio/src/io/vov/vitamio/provider/MediaStore.java on lines 256..264

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 78.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status