yast/yast-bootloader

View on GitHub
src/lib/bootloader/grub2base.rb

Summary

Maintainability
C
1 day
Test Coverage

Class Grub2Base has 35 methods (exceeds 20 allowed). Consider refactoring.
Open

  class Grub2Base < BootloaderBase
    include Yast::Logger
    include Yast::I18n

    # @!attribute password
Severity: Minor
Found in src/lib/bootloader/grub2base.rb - About 4 hrs to fix

    File grub2base.rb has 322 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    require "yast"
    require "yast2/execute"
    require "yast2/target_file" # adds ability to work with cfa in inst-sys
    require "bootloader/bootloader_base"
    require "bootloader/exceptions"
    Severity: Minor
    Found in src/lib/bootloader/grub2base.rb - About 3 hrs to fix

      Method merge_attributes has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          def merge_attributes(default, other)
            # string attributes
            [:serial_console, :timeout, :hidden_timeout, :distributor,
             :gfxmode, :theme, :default].each do |attr|
              val = other.public_send(attr)
      Severity: Minor
      Found in src/lib/bootloader/grub2base.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method propose_terminal has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          def propose_terminal
            begin
              return if grub_default.terminal
            rescue RuntimeError => e
              log.info "Proposing terminal again due to #{e}"
      Severity: Minor
      Found in src/lib/bootloader/grub2base.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method merge has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          def merge(other)
            super
      
            merge_grub_default(other)
            merge_password(other)
      Severity: Minor
      Found in src/lib/bootloader/grub2base.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

          def update_nvram_summary
            link = if update_nvram
              "<a href=\"disable_update_nvram\">(#{_("disable")})</a>"
            else
              "<a href=\"enable_update_nvram\">(#{_("enable")})</a>"
      Severity: Minor
      Found in src/lib/bootloader/grub2base.rb and 3 other locations - About 15 mins to fix
      src/lib/bootloader/grub2base.rb on lines 422..429
      src/lib/bootloader/grub2base.rb on lines 435..442
      src/lib/bootloader/systemdboot.rb on lines 82..89

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 26.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

          def secure_boot_summary
            link = if secure_boot
              "<a href=\"disable_secure_boot\">(#{_("disable")})</a>"
            else
              "<a href=\"enable_secure_boot\">(#{_("enable")})</a>"
      Severity: Minor
      Found in src/lib/bootloader/grub2base.rb and 3 other locations - About 15 mins to fix
      src/lib/bootloader/grub2base.rb on lines 435..442
      src/lib/bootloader/grub2base.rb on lines 448..455
      src/lib/bootloader/systemdboot.rb on lines 82..89

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 26.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

          def trusted_boot_summary
            link = if trusted_boot
              "<a href=\"disable_trusted_boot\">(#{_("disable")})</a>"
            else
              "<a href=\"enable_trusted_boot\">(#{_("enable")})</a>"
      Severity: Minor
      Found in src/lib/bootloader/grub2base.rb and 3 other locations - About 15 mins to fix
      src/lib/bootloader/grub2base.rb on lines 422..429
      src/lib/bootloader/grub2base.rb on lines 448..455
      src/lib/bootloader/systemdboot.rb on lines 82..89

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 26.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status