Sign upLogin

yast/yast-yast2

View on GitHub
Star
library/cwm/src/modules/CWMServiceStart.rb

Summary

Maintainability
F
3 days
Test Coverage

File CWMServiceStart.rb has 531 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require "yast"

module Yast
  # Routines for service start widget handling.
  #
Severity: Major
Found in library/cwm/src/modules/CWMServiceStart.rb - About 1 day to fix

    Method CreateStartStopWidget has 88 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def CreateStartStopWidget(settings)
      settings = deep_copy(settings)

      start_now_button = Ops.get_locale(
        settings,
    Severity: Major
    Found in library/cwm/src/modules/CWMServiceStart.rb - About 3 hrs to fix

      Method CreateAutoStartWidget has 84 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          def CreateAutoStartWidget(settings)
      settings = deep_copy(settings)

      start_auto_button = Ops.get_locale(
        settings,
      Severity: Major
      Found in library/cwm/src/modules/CWMServiceStart.rb - About 3 hrs to fix

        Class CWMServiceStartClass has 27 methods (exceeds 20 allowed). Consider refactoring.
        Open

          class CWMServiceStartClass < Module
    def main
      Yast.import "UI"
      textdomain "base"
        Severity: Minor
        Found in library/cwm/src/modules/CWMServiceStart.rb - About 3 hrs to fix

          Method CreateLdapWidget has 40 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              def CreateLdapWidget(settings)
      settings = deep_copy(settings)

      use_ldap_checkbox = Ops.get_locale(
        settings,
          Severity: Minor
          Found in library/cwm/src/modules/CWMServiceStart.rb - About 1 hr to fix

            Method StartStopHandle has 39 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                def StartStopHandle(widget, _key, event)
      widget = deep_copy(widget)
      event = deep_copy(event)
      event_id = Ops.get(event, "ID")
      case event_id
            Severity: Minor
            Found in library/cwm/src/modules/CWMServiceStart.rb - About 1 hr to fix

              Method AutoStartInit has 31 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  def AutoStartInit(widget, _key)
      widget = deep_copy(widget)
      if !UI.WidgetExists(Id("_cwm_service_startup"))
        Builtins.y2error("Widget _cwm_service_startup does not exist")
        return
              Severity: Minor
              Found in library/cwm/src/modules/CWMServiceStart.rb - About 1 hr to fix

                Method UpdateServiceStatusWidget has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                Open

                    def UpdateServiceStatusWidget(widget)
      widget = deep_copy(widget)
      return if !UI.WidgetExists(Id("_cwm_service_status_rp"))

      if Mode.config
                Severity: Minor
                Found in library/cwm/src/modules/CWMServiceStart.rb - About 55 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method StartStopHandle has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                Open

                    def StartStopHandle(widget, _key, event)
      widget = deep_copy(widget)
      event = deep_copy(event)
      event_id = Ops.get(event, "ID")
      case event_id
                Severity: Minor
                Found in library/cwm/src/modules/CWMServiceStart.rb - About 35 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method AutoStartInit has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                    def AutoStartInit(widget, _key)
      widget = deep_copy(widget)
      if !UI.WidgetExists(Id("_cwm_service_startup"))
        Builtins.y2error("Widget _cwm_service_startup does not exist")
        return
                Severity: Minor
                Found in library/cwm/src/modules/CWMServiceStart.rb - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method CreateStartStopWidget has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                    def CreateStartStopWidget(settings)
      settings = deep_copy(settings)

      start_now_button = Ops.get_locale(
        settings,
                Severity: Minor
                Found in library/cwm/src/modules/CWMServiceStart.rb - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method CreateAutoStartWidget has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                    def CreateAutoStartWidget(settings)
      settings = deep_copy(settings)

      start_auto_button = Ops.get_locale(
        settings,
                Severity: Minor
                Found in library/cwm/src/modules/CWMServiceStart.rb - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                      when "_cwm_stop_service_now"
        if Builtins.haskey(widget, "stop_now_action")
          stop_now_func = Convert.convert(
            Ops.get(widget, "stop_now_action"),
            from: "any",
                Severity: Minor
                Found in library/cwm/src/modules/CWMServiceStart.rb and 1 other location - About 30 mins to fix
                library/cwm/src/modules/CWMServiceStart.rb on lines 418..429

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 33.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                      when "_cwm_start_service_now"
        if Builtins.haskey(widget, "start_now_action")
          start_now_func = Convert.convert(
            Ops.get(widget, "start_now_action"),
            from: "any",
                Severity: Minor
                Found in library/cwm/src/modules/CWMServiceStart.rb and 1 other location - About 30 mins to fix
                library/cwm/src/modules/CWMServiceStart.rb on lines 430..441

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 33.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status