Sign upLogin

yast/yast-yast2

View on GitHub
Star
library/network/src/modules/NetworkService.rb

Summary

Maintainability
C
7 hrs
Test Coverage

Class NetworkServiceClass has 35 methods (exceeds 20 allowed). Consider refactoring.
Open

  class NetworkServiceClass < Module
    # return [String, nil] current network backend identification, nil is valid value for "no service selected / running"
    attr_accessor :current_name
    # return [String, nil] new network backend identification, nil is valid value for "no service selected / running"
    attr_writer :cached_name
Severity: Minor
Found in library/network/src/modules/NetworkService.rb - About 4 hrs to fix

    File NetworkService.rb has 292 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    require "yast"
require "yast2/systemd/service"
require "shellwords"

module Yast
    Severity: Minor
    Found in library/network/src/modules/NetworkService.rb - About 3 hrs to fix

      Method EnableDisableNow has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          def EnableDisableNow(force: false)
      return unless force || Modified()

      if current_name && Modified()
        stop_service(current_name)
      Severity: Minor
      Found in library/network/src/modules/NetworkService.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status