yegor256/pgtk

View on GitHub

Showing 7 of 7 total issues

Method run has 73 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def run
    raise "Option 'dir' is mandatory" unless @dir
    raise "Option 'yaml' is mandatory" unless @yaml
    home = File.expand_path(@dir)
    FileUtils.rm_rf(home) if @fresh_start
Severity: Major
Found in lib/pgtk/pgsql_task.rb - About 2 hrs to fix

    Method run has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
    Open

      def run
        raise "Option 'dir' is mandatory" unless @dir
        raise "Option 'yaml' is mandatory" unless @yaml
        home = File.expand_path(@dir)
        FileUtils.rm_rf(home) if @fresh_start
    Severity: Minor
    Found in lib/pgtk/pgsql_task.rb - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method run has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
    Open

      def run
        raise "Option 'master' is mandatory" unless @master
        raise "Option 'yaml' is mandatory" unless @yaml
        yml = YAML.load_file(
          if @yaml.is_a?(Array)
    Severity: Minor
    Found in lib/pgtk/liquibase_task.rb - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method run has 35 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def run
        raise "Option 'master' is mandatory" unless @master
        raise "Option 'yaml' is mandatory" unless @yaml
        yml = YAML.load_file(
          if @yaml.is_a?(Array)
    Severity: Minor
    Found in lib/pgtk/liquibase_task.rb - About 1 hr to fix

      Method exec has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          def exec(query, args = [], result = 0)
            start = Time.now
            sql = query.is_a?(Array) ? query.join(' ') : query
            out = @conn.exec_params(sql, args, result) do |res|
              if block_given?
      Severity: Minor
      Found in lib/pgtk/pool.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method initialize has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

        def initialize(*args, &task_block)
          @name = args.shift || :pgsql
          @fresh_start = false
          @quite = false
          @user = 'test'
      Severity: Minor
      Found in lib/pgtk/pgsql_task.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method initialize has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

        def initialize(*args, &task_block)
          @name = args.shift || :liquibase
          @quite = false
          unless ::Rake.application.last_description
            desc 'Deploy Liquibase changes to the running PostgreSQL server'
      Severity: Minor
      Found in lib/pgtk/liquibase_task.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language