yiisoft/yii2

View on GitHub
framework/base/ActionFilter.php

Summary

Maintainability
A
1 hr
Test Coverage

Function isActive has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

    protected function isActive($action)
    {
        $id = $this->getActionId($action);

        if (empty($this->only)) {
Severity: Minor
Found in framework/base/ActionFilter.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid unused parameters such as '$action'.
Open

    public function beforeAction($action)
Severity: Minor
Found in framework/base/ActionFilter.php by phpmd

Since: PHPMD 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example:

class Foo
  {
      private function bar($howdy)
      {
          // $howdy is not used
      }
  }

Source: http://phpmd.org/rules/unusedcode.txt

Avoid unused parameters such as '$action'.
Open

    public function afterAction($action, $result)
Severity: Minor
Found in framework/base/ActionFilter.php by phpmd

Since: PHPMD 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example:

class Foo
  {
      private function bar($howdy)
      {
          // $howdy is not used
      }
  }

Source: http://phpmd.org/rules/unusedcode.txt

There are no issues that match your filters.

Category
Status