yiisoft/yii2

View on GitHub
framework/console/widgets/Table.php

Summary

Maintainability
C
1 day
Test Coverage

Function renderRow has a Cognitive Complexity of 35 (exceeds 5 allowed). Consider refactoring.
Open

    protected function renderRow(array $row, $spanLeft, $spanMiddle, $spanRight)
    {
        $size = $this->columnWidths;

        $buffer = '';
Severity: Minor
Found in framework/console/widgets/Table.php - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

The class Table has an overall complexity of 54 which is very high. The configured complexity threshold is 50.
Open

class Table extends Widget
{
    const DEFAULT_CONSOLE_SCREEN_WIDTH = 120;
    const CONSOLE_SCROLLBAR_OFFSET = 3;
    const CHAR_TOP = 'top';
Severity: Minor
Found in framework/console/widgets/Table.php by phpmd

Function calculateRowsSize has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

    protected function calculateRowsSize()
    {
        $this->columnWidths = $columns = [];
        $totalWidth = 0;
        $screenWidth = $this->getScreenWidth() - self::CONSOLE_SCROLLBAR_OFFSET;
Severity: Minor
Found in framework/console/widgets/Table.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this method.
Open

        return max($rowsPerCell);
Severity: Major
Found in framework/console/widgets/Table.php - About 30 mins to fix

    Avoid too many return statements within this method.
    Open

                return Console::ansiStrwidth($val);
    Severity: Major
    Found in framework/console/widgets/Table.php - About 30 mins to fix

      The method renderRow() has an NPath complexity of 386. The configured NPath complexity threshold is 200.
      Open

          protected function renderRow(array $row, $spanLeft, $spanMiddle, $spanRight)
          {
              $size = $this->columnWidths;
      
              $buffer = '';
      Severity: Minor
      Found in framework/console/widgets/Table.php by phpmd

      NPathComplexity

      Since: 0.1

      The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

      Example

      class Foo {
          function bar() {
              // lots of complicated code
          }
      }

      Source https://phpmd.org/rules/codesize.html#npathcomplexity

      The method calculateRowsSize() has an NPath complexity of 300. The configured NPath complexity threshold is 200.
      Open

          protected function calculateRowsSize()
          {
              $this->columnWidths = $columns = [];
              $totalWidth = 0;
              $screenWidth = $this->getScreenWidth() - self::CONSOLE_SCROLLBAR_OFFSET;
      Severity: Minor
      Found in framework/console/widgets/Table.php by phpmd

      NPathComplexity

      Since: 0.1

      The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

      Example

      class Foo {
          function bar() {
              // lots of complicated code
          }
      }

      Source https://phpmd.org/rules/codesize.html#npathcomplexity

      The method renderRow() has a Cyclomatic Complexity of 15. The configured cyclomatic complexity threshold is 10.
      Open

          protected function renderRow(array $row, $spanLeft, $spanMiddle, $spanRight)
          {
              $size = $this->columnWidths;
      
              $buffer = '';
      Severity: Minor
      Found in framework/console/widgets/Table.php by phpmd

      CyclomaticComplexity

      Since: 0.1

      Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

      Example

      // Cyclomatic Complexity = 11
      class Foo {
      1   public function example() {
      2       if ($a == $b) {
      3           if ($a1 == $b1) {
                      fiddle();
      4           } elseif ($a2 == $b2) {
                      fiddle();
                  } else {
                      fiddle();
                  }
      5       } elseif ($c == $d) {
      6           while ($c == $d) {
                      fiddle();
                  }
      7        } elseif ($e == $f) {
      8           for ($n = 0; $n < $h; $n++) {
                      fiddle();
                  }
              } else {
                  switch ($z) {
      9               case 1:
                          fiddle();
                          break;
      10              case 2:
                          fiddle();
                          break;
      11              case 3:
                          fiddle();
                          break;
                      default:
                          fiddle();
                          break;
                  }
              }
          }
      }

      Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

      The method calculateRowsSize() has a Cyclomatic Complexity of 12. The configured cyclomatic complexity threshold is 10.
      Open

          protected function calculateRowsSize()
          {
              $this->columnWidths = $columns = [];
              $totalWidth = 0;
              $screenWidth = $this->getScreenWidth() - self::CONSOLE_SCROLLBAR_OFFSET;
      Severity: Minor
      Found in framework/console/widgets/Table.php by phpmd

      CyclomaticComplexity

      Since: 0.1

      Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

      Example

      // Cyclomatic Complexity = 11
      class Foo {
      1   public function example() {
      2       if ($a == $b) {
      3           if ($a1 == $b1) {
                      fiddle();
      4           } elseif ($a2 == $b2) {
                      fiddle();
                  } else {
                      fiddle();
                  }
      5       } elseif ($c == $d) {
      6           while ($c == $d) {
                      fiddle();
                  }
      7        } elseif ($e == $f) {
      8           for ($n = 0; $n < $h; $n++) {
                      fiddle();
                  }
              } else {
                  switch ($z) {
      9               case 1:
                          fiddle();
                          break;
      10              case 2:
                          fiddle();
                          break;
      11              case 3:
                          fiddle();
                          break;
                      default:
                          fiddle();
                          break;
                  }
              }
          }
      }

      Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

      There are no issues that match your filters.

      Category
      Status