yiisoft/yii2

View on GitHub
framework/db/ColumnSchema.php

Summary

Maintainability
B
4 hrs
Test Coverage

Function typecast has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

    protected function typecast($value)
    {
        if ($value === ''
            && !in_array(
                $this->type,
Severity: Minor
Found in framework/db/ColumnSchema.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this method.
Open

                return (int) $value;
Severity: Major
Found in framework/db/ColumnSchema.php - About 30 mins to fix

    Avoid too many return statements within this method.
    Open

                        return StringHelper::floatToString($value);
    Severity: Major
    Found in framework/db/ColumnSchema.php - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

              return $value;
      Severity: Major
      Found in framework/db/ColumnSchema.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                        return (bool) $value && $value !== "\0";
        Severity: Major
        Found in framework/db/ColumnSchema.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                          return (string) $value;
          Severity: Major
          Found in framework/db/ColumnSchema.php - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                            return (float) $value;
            Severity: Major
            Found in framework/db/ColumnSchema.php - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                                  return $value;
              Severity: Major
              Found in framework/db/ColumnSchema.php - About 30 mins to fix

                The method typecast() has an NPath complexity of 1200. The configured NPath complexity threshold is 200.
                Open

                    protected function typecast($value)
                    {
                        if ($value === ''
                            && !in_array(
                                $this->type,
                Severity: Minor
                Found in framework/db/ColumnSchema.php by phpmd

                NPathComplexity

                Since: 0.1

                The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

                Example

                class Foo {
                    function bar() {
                        // lots of complicated code
                    }
                }

                Source https://phpmd.org/rules/codesize.html#npathcomplexity

                The method typecast() has a Cyclomatic Complexity of 21. The configured cyclomatic complexity threshold is 10.
                Open

                    protected function typecast($value)
                    {
                        if ($value === ''
                            && !in_array(
                                $this->type,
                Severity: Minor
                Found in framework/db/ColumnSchema.php by phpmd

                CyclomaticComplexity

                Since: 0.1

                Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

                Example

                // Cyclomatic Complexity = 11
                class Foo {
                1   public function example() {
                2       if ($a == $b) {
                3           if ($a1 == $b1) {
                                fiddle();
                4           } elseif ($a2 == $b2) {
                                fiddle();
                            } else {
                                fiddle();
                            }
                5       } elseif ($c == $d) {
                6           while ($c == $d) {
                                fiddle();
                            }
                7        } elseif ($e == $f) {
                8           for ($n = 0; $n < $h; $n++) {
                                fiddle();
                            }
                        } else {
                            switch ($z) {
                9               case 1:
                                    fiddle();
                                    break;
                10              case 2:
                                    fiddle();
                                    break;
                11              case 3:
                                    fiddle();
                                    break;
                                default:
                                    fiddle();
                                    break;
                            }
                        }
                    }
                }

                Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

                Avoid using undefined variables such as '$typeCategoryMap' which will lead to PHP notices.
                Open

                                    && ColumnSchemaBuilder::CATEGORY_NUMERIC === ColumnSchemaBuilder::$typeCategoryMap[$this->type]
                Severity: Minor
                Found in framework/db/ColumnSchema.php by phpmd

                UndefinedVariable

                Since: 2.8.0

                Detects when a variable is used that has not been defined before.

                Example

                class Foo
                {
                    private function bar()
                    {
                        // $message is undefined
                        echo $message;
                    }
                }

                Source https://phpmd.org/rules/cleancode.html#undefinedvariable

                There are no issues that match your filters.

                Category
                Status