yiisoft/yii2

View on GitHub
framework/db/Command.php

Summary

Maintainability
C
7 hrs
Test Coverage

The class Command has an overall complexity of 126 which is very high. The configured complexity threshold is 50.
Open

class Command extends Component
{
    /**
     * @var Connection the DB connection that this command is associated with
     */
Severity: Minor
Found in framework/db/Command.php by phpmd

Since: PHPMD 0.2.5

The Weighted Method Count (WMC) of a class is a good indicator of how much time and effort is required to modify and maintain this class. The WMC metric is defined as the sum of complexities of all methods declared in a class. A large number of methods also means that this class has a greater potential impact on derived classes.

Example:

class Foo {
      public function bar() {
          if ($a == $b)  {
              if ($a1 == $b1) {
                  fiddle();
              } elseif ($a2 == $b2) {
                  fiddle();
              } else {
              }
          }
      }
      public function baz() {
          if ($a == $b) {
              if ($a1 == $b1) {
                  fiddle();
              } elseif ($a2 == $b2) {
                  fiddle();
              } else {
              }
          }
      }
      // Several other complex methods
  }

Source: http://phpmd.org/rules/codesize.txt

The class Command has 55 non-getter- and setter-methods. Consider refactoring Command to keep number of methods under 25.
Open

class Command extends Component
{
    /**
     * @var Connection the DB connection that this command is associated with
     */
Severity: Minor
Found in framework/db/Command.php by phpmd

Since: PHPMD 0.1

A class with too many methods is probably a good suspect for refactoring, in order to reduce its complexity and find a way to have more fine grained objects. By default it ignores methods starting with 'get' or 'set'. The default was changed from 10 to 25 in PHPMD 2.3.

Source: http://phpmd.org/rules/codesize.txt

The class Command has 47 public methods. Consider refactoring Command to keep number of public methods under 10.
Open

class Command extends Component
{
    /**
     * @var Connection the DB connection that this command is associated with
     */
Severity: Minor
Found in framework/db/Command.php by phpmd

Since: PHPMD 0.1

A class with too many public methods is probably a good suspect for refactoring, in order to reduce its complexity and find a way to have more fine grained objects. By default it ignores methods starting with 'get' or 'set'.

Source: http://phpmd.org/rules/codesize.txt

Function getRawSql has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

    public function getRawSql()
    {
        if (empty($this->params)) {
            return $this->_sql;
        }
Severity: Minor
Found in framework/db/Command.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function queryInternal has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

    protected function queryInternal($method, $fetchMode = null)
    {
        list($profile, $rawSql) = $this->logQuery('yii\db\Command::query');

        if ($method !== '') {
Severity: Minor
Found in framework/db/Command.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function internalExecute has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

    protected function internalExecute($rawSql)
    {
        $attempt = 0;
        while (true) {
            try {
Severity: Minor
Found in framework/db/Command.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

The class Command has 57 public methods and attributes. Consider reducing the number of public items to less than 45.
Open

class Command extends Component
{
    /**
     * @var Connection the DB connection that this command is associated with
     */
Severity: Minor
Found in framework/db/Command.php by phpmd

Since: PHPMD 0.1

A large number of public methods and attributes declared in a class can indicate the class may need to be broken up as increased effort will be required to thoroughly test it.

Example:

public class Foo {
      public $value;
      public $something;
      public $var;
      // [... more more public attributes ...]

      public function doWork() {}
      public function doMoreWork() {}
      public function doWorkAgain() {}
      // [... more more public methods ...]
  }

Source: http://phpmd.org/rules/codesize.txt

Method addForeignKey has 7 arguments (exceeds 4 allowed). Consider refactoring.
Open

    public function addForeignKey($name, $table, $columns, $refTable, $refColumns, $delete = null, $update = null)
Severity: Major
Found in framework/db/Command.php - About 50 mins to fix

    Method bindParam has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        public function bindParam($name, &$value, $dataType = null, $length = null, $driverOptions = null)
    Severity: Minor
    Found in framework/db/Command.php - About 35 mins to fix

      Function prepare has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          public function prepare($forRead = null)
          {
              if ($this->pdoStatement) {
                  $this->bindPendingParams();
                  return;
      Severity: Minor
      Found in framework/db/Command.php - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function bindValues has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          public function bindValues($values)
          {
              if (empty($values)) {
                  return $this;
              }
      Severity: Minor
      Found in framework/db/Command.php - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      The method getRawSql() has an NPath complexity of 300. The configured NPath complexity threshold is 200.
      Open

          public function getRawSql()
          {
              if (empty($this->params)) {
                  return $this->_sql;
              }
      Severity: Minor
      Found in framework/db/Command.php by phpmd

      Since: PHPMD 0.1

      The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

      Example:

      class Foo {
            function bar() {
                // lots of complicated code
            }
        }

      Source: http://phpmd.org/rules/codesize.txt

      The class Command has 1261 lines of code. Current threshold is 1000. Avoid really long classes.
      Open

      class Command extends Component
      {
          /**
           * @var Connection the DB connection that this command is associated with
           */
      Severity: Minor
      Found in framework/db/Command.php by phpmd

      The method getRawSql() has a Cyclomatic Complexity of 15. The configured cyclomatic complexity threshold is 10.
      Open

          public function getRawSql()
          {
              if (empty($this->params)) {
                  return $this->_sql;
              }
      Severity: Minor
      Found in framework/db/Command.php by phpmd

      Since: PHPMD 0.1

      Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

      Example:

      // Cyclomatic Complexity = 11
        class Foo {
        1   public function example() {
        2       if ($a == $b) {
        3           if ($a1 == $b1) {
                        fiddle();
        4           } elseif ($a2 == $b2) {
                        fiddle();
                    } else {
                        fiddle();
                    }
        5       } elseif ($c == $d) {
        6           while ($c == $d) {
                        fiddle();
                    }
        7        } elseif ($e == $f) {
        8           for ($n = 0; $n < $h; $n++) {
                        fiddle();
                    }
                } else {
                    switch ($z) {
        9               case 1:
                            fiddle();
                            break;
        10              case 2:
                            fiddle();
                            break;
        11              case 3:
                            fiddle();
                            break;
                        default:
                            fiddle();
                            break;
                    }
                }
            }
        }

      Source: http://phpmd.org/rules/codesize.txt

      The method queryInternal() has a Cyclomatic Complexity of 13. The configured cyclomatic complexity threshold is 10.
      Open

          protected function queryInternal($method, $fetchMode = null)
          {
              list($profile, $rawSql) = $this->logQuery('yii\db\Command::query');
      
              if ($method !== '') {
      Severity: Minor
      Found in framework/db/Command.php by phpmd

      Since: PHPMD 0.1

      Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

      Example:

      // Cyclomatic Complexity = 11
        class Foo {
        1   public function example() {
        2       if ($a == $b) {
        3           if ($a1 == $b1) {
                        fiddle();
        4           } elseif ($a2 == $b2) {
                        fiddle();
                    } else {
                        fiddle();
                    }
        5       } elseif ($c == $d) {
        6           while ($c == $d) {
                        fiddle();
                    }
        7        } elseif ($e == $f) {
        8           for ($n = 0; $n < $h; $n++) {
                        fiddle();
                    }
                } else {
                    switch ($z) {
        9               case 1:
                            fiddle();
                            break;
        10              case 2:
                            fiddle();
                            break;
        11              case 3:
                            fiddle();
                            break;
                        default:
                            fiddle();
                            break;
                    }
                }
            }
        }

      Source: http://phpmd.org/rules/codesize.txt

      The class Command has a coupling between objects value of 16. Consider to reduce the number of dependencies under 13.
      Open

      class Command extends Component
      {
          /**
           * @var Connection the DB connection that this command is associated with
           */
      Severity: Minor
      Found in framework/db/Command.php by phpmd

      Since: PHPMD 1.1.0

      A class with too many dependencies has negative impacts on several quality aspects of a class. This includes quality criteria like stability, maintainability and understandability

      Example:

      class Foo {
            /**
             * @var \foo\bar\X
             */
            private $x = null;
      
            /**
             * @var \foo\bar\Y
             */
            private $y = null;
      
            /**
             * @var \foo\bar\Z
             */
            private $z = null;
      
            public function setFoo(\Foo $foo) {}
            public function setBar(\Bar $bar) {}
            public function setBaz(\Baz $baz) {}
      
            /**
             * @return \SplObjectStorage
             * @throws \OutOfRangeException
             * @throws \InvalidArgumentException
             * @throws \ErrorException
             */
            public function process(\Iterator $it) {}
      
            // ...
        }

      Source: http://phpmd.org/rules/design.txt

      The method checkIntegrity has a boolean flag argument $check, which is a certain sign of a Single Responsibility Principle violation.
      Open

          public function checkIntegrity($check = true, $schema = '', $table = '')
      Severity: Minor
      Found in framework/db/Command.php by phpmd

      Since: PHPMD 1.4.0

      A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

      Example:

      class Foo {
            public function bar($flag = true) {
            }
        }

      Source: http://phpmd.org/rules/cleancode.txt

      The method upsert has a boolean flag argument $updateColumns, which is a certain sign of a Single Responsibility Principle violation.
      Open

          public function upsert($table, $insertColumns, $updateColumns = true, $params = [])
      Severity: Minor
      Found in framework/db/Command.php by phpmd

      Since: PHPMD 1.4.0

      A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

      Example:

      class Foo {
            public function bar($flag = true) {
            }
        }

      Source: http://phpmd.org/rules/cleancode.txt

      The method createIndex has a boolean flag argument $unique, which is a certain sign of a Single Responsibility Principle violation.
      Open

          public function createIndex($name, $table, $columns, $unique = false)
      Severity: Minor
      Found in framework/db/Command.php by phpmd

      Since: PHPMD 1.4.0

      A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

      Example:

      class Foo {
            public function bar($flag = true) {
            }
        }

      Source: http://phpmd.org/rules/cleancode.txt

      TODO found
      Open

                  if (is_array($value)) { // TODO: Drop in Yii 2.1
      Severity: Minor
      Found in framework/db/Command.php by fixme

      There are no issues that match your filters.

      Category
      Status