# yiisoft/yii2

framework/db/Query.php

### Summary

C
1 day

#### The class Query has an overall complexity of 141 which is very high. The configured complexity threshold is 50. Open

class Query extends Component implements QueryInterface, ExpressionInterface
{
use QueryTrait;

/**
Found in framework/db/Query.php by phpmd

Since: PHPMD 0.2.5

The Weighted Method Count (WMC) of a class is a good indicator of how much time and effort is required to modify and maintain this class. The WMC metric is defined as the sum of complexities of all methods declared in a class. A large number of methods also means that this class has a greater potential impact on derived classes.

Example:

class Foo {
public function bar() {
if ($a ==$b)  {
if ($a1 ==$b1) {
fiddle();
} elseif ($a2 ==$b2) {
fiddle();
} else {
}
}
}
public function baz() {
if ($a ==$b) {
if ($a1 ==$b1) {
fiddle();
} elseif ($a2 ==$b2) {
fiddle();
} else {
}
}
}
// Several other complex methods
}

#### The class Query has 43 public methods. Consider refactoring Query to keep number of public methods under 10. Open

class Query extends Component implements QueryInterface, ExpressionInterface
{
use QueryTrait;

/**
Found in framework/db/Query.php by phpmd

Since: PHPMD 0.1

A class with too many public methods is probably a good suspect for refactoring, in order to reduce its complexity and find a way to have more fine grained objects. By default it ignores methods starting with 'get' or 'set'.

Source: http://phpmd.org/rules/codesize.txt

#### The class Query has 47 non-getter- and setter-methods. Consider refactoring Query to keep number of methods under 25. Open

class Query extends Component implements QueryInterface, ExpressionInterface
{
use QueryTrait;

/**
Found in framework/db/Query.php by phpmd

Since: PHPMD 0.1

A class with too many methods is probably a good suspect for refactoring, in order to reduce its complexity and find a way to have more fine grained objects. By default it ignores methods starting with 'get' or 'set'. The default was changed from 10 to 25 in PHPMD 2.3.

Source: http://phpmd.org/rules/codesize.txt

#### Function cleanUpTableNames has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring. Open

    protected function cleanUpTableNames($tableNames) {$cleanedUpTableNames = [];
foreach ($tableNames as$alias => $tableName) { if (is_string($tableName) && !is_string($alias)) { Found in framework/db/Query.php - About 2 hrs to fix # Cognitive Complexity Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend. ### A method's cognitive complexity is based on a few simple rules: • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one • Code is considered more complex for each "break in the linear flow of the code" • Code is considered more complex when "flow breaking structures are nested" ### Further reading #### Function getUniqueColumns has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring. Open  protected function getUniqueColumns($columns)
{
$unaliasedColumns =$this->getUnaliasedColumnsFromSelect();

$result = []; Found in framework/db/Query.php - About 2 hrs to fix # Cognitive Complexity Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend. ### A method's cognitive complexity is based on a few simple rules: • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one • Code is considered more complex for each "break in the linear flow of the code" • Code is considered more complex when "flow breaking structures are nested" ### Further reading #### Function normalizeSelect has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring. Open  protected function normalizeSelect($columns)
{
if ($columns instanceof ExpressionInterface) {$columns = [$columns]; } elseif (!is_array($columns)) {
Found in framework/db/Query.php - About 2 hrs to fix

# Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

### A method's cognitive complexity is based on a few simple rules:

• Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
• Code is considered more complex for each "break in the linear flow of the code"
• Code is considered more complex when "flow breaking structures are nested"

#### Function column has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring. Open

    public function column($db = null) { if ($this->emulateExecution) {
return [];
}
Found in framework/db/Query.php - About 2 hrs to fix

# Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

### A method's cognitive complexity is based on a few simple rules:

• Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
• Code is considered more complex for each "break in the linear flow of the code"
• Code is considered more complex when "flow breaking structures are nested"

#### Function addParams has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring. Open

    public function addParams($params) { if (!empty($params)) {
if (empty($this->params)) {$this->params = $params; Found in framework/db/Query.php - About 1 hr to fix # Cognitive Complexity Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend. ### A method's cognitive complexity is based on a few simple rules: • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one • Code is considered more complex for each "break in the linear flow of the code" • Code is considered more complex when "flow breaking structures are nested" ### Further reading #### The class Query has 56 public methods and attributes. Consider reducing the number of public items to less than 45. Open class Query extends Component implements QueryInterface, ExpressionInterface { use QueryTrait; /** Found in framework/db/Query.php by phpmd Since: PHPMD 0.1 A large number of public methods and attributes declared in a class can indicate the class may need to be broken up as increased effort will be required to thoroughly test it. Example: public class Foo { public$value;
public $something; public$var;
// [... more more public attributes ...]

public function doWork() {}
public function doMoreWork() {}
public function doWorkAgain() {}
// [... more more public methods ...]
}

#### Function queryScalar has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring. Open

    protected function queryScalar($selectExpression,$db)
{
if ($this->emulateExecution) { return null; } Found in framework/db/Query.php - About 55 mins to fix # Cognitive Complexity Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend. ### A method's cognitive complexity is based on a few simple rules: • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one • Code is considered more complex for each "break in the linear flow of the code" • Code is considered more complex when "flow breaking structures are nested" ### Further reading #### Function getUnaliasedColumnsFromSelect has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open  protected function getUnaliasedColumnsFromSelect() {$result = [];
if (is_array($this->select)) { foreach ($this->select as $name =>$value) {
Found in framework/db/Query.php - About 25 mins to fix

# Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

### A method's cognitive complexity is based on a few simple rules:

• Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
• Code is considered more complex for each "break in the linear flow of the code"
• Code is considered more complex when "flow breaking structures are nested"

#### The class Query has 1347 lines of code. Current threshold is 1000. Avoid really long classes. Open

class Query extends Component implements QueryInterface, ExpressionInterface
{
use QueryTrait;

/**
Found in framework/db/Query.php by phpmd

#### The method column() has an NPath complexity of 216. The configured NPath complexity threshold is 200. Open

    public function column($db = null) { if ($this->emulateExecution) {
return [];
}
Found in framework/db/Query.php by phpmd

Since: PHPMD 0.1

The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

Example:

class Foo {
function bar() {
// lots of complicated code
}
}

#### The method column() has a Cyclomatic Complexity of 12. The configured cyclomatic complexity threshold is 10. Open

    public function column($db = null) { if ($this->emulateExecution) {
return [];
}
Found in framework/db/Query.php by phpmd

Since: PHPMD 0.1

Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

Example:

// Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a ==$b) {
3           if ($a1 ==$b1) {
fiddle();
4           } elseif ($a2 ==$b2) {
fiddle();
} else {
fiddle();
}
5       } elseif ($c ==$d) {
6           while ($c ==$d) {
fiddle();
}
7        } elseif ($e ==$f) {
8           for ($n = 0;$n < $h;$n++) {
fiddle();
}
} else {
switch ($z) { 9 case 1: fiddle(); break; 10 case 2: fiddle(); break; 11 case 3: fiddle(); break; default: fiddle(); break; } } } } #### The method normalizeSelect() has a Cyclomatic Complexity of 10. The configured cyclomatic complexity threshold is 10. Open  protected function normalizeSelect($columns)
{
if ($columns instanceof ExpressionInterface) {$columns = [$columns]; } elseif (!is_array($columns)) {
Found in framework/db/Query.php by phpmd

Since: PHPMD 0.1

Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

Example:

// Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a ==$b) {
3           if ($a1 ==$b1) {
fiddle();
4           } elseif ($a2 ==$b2) {
fiddle();
} else {
fiddle();
}
5       } elseif ($c ==$d) {
6           while ($c ==$d) {
fiddle();
}
7        } elseif ($e ==$f) {
8           for ($n = 0;$n < $h;$n++) {
fiddle();
}
} else {
switch ($z) { 9 case 1: fiddle(); break; 10 case 2: fiddle(); break; 11 case 3: fiddle(); break; default: fiddle(); break; } } } } #### The class Query has a coupling between objects value of 13. Consider to reduce the number of dependencies under 13. Open class Query extends Component implements QueryInterface, ExpressionInterface { use QueryTrait; /** Found in framework/db/Query.php by phpmd Since: PHPMD 1.1.0 A class with too many dependencies has negative impacts on several quality aspects of a class. This includes quality criteria like stability, maintainability and understandability Example: class Foo { /** * @var \foo\bar\X */ private$x = null;

/**
* @var \foo\bar\Y
*/
private $y = null; /** * @var \foo\bar\Z */ private$z = null;

public function setFoo(\Foo $foo) {} public function setBar(\Bar$bar) {}
public function setBaz(\Baz $baz) {} /** * @return \SplObjectStorage * @throws \OutOfRangeException * @throws \InvalidArgumentException * @throws \ErrorException */ public function process(\Iterator$it) {}

// ...
}

#### The method distinct has a boolean flag argument $value, which is a certain sign of a Single Responsibility Principle violation. Open  public function distinct($value = true)
Found in framework/db/Query.php by phpmd

Since: PHPMD 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example:

class Foo {
public function bar($flag = true) { } } #### The method cache has a boolean flag argument$duration, which is a certain sign of a Single Responsibility Principle violation. Open

    public function cache($duration = true,$dependency = null)
Found in framework/db/Query.php by phpmd

Since: PHPMD 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example:

class Foo {
public function bar($flag = true) { } } #### The method withQuery has a boolean flag argument$recursive, which is a certain sign of a Single Responsibility Principle violation. Open

    public function withQuery($query,$alias, $recursive = false) Found in framework/db/Query.php by phpmd Since: PHPMD 1.4.0 A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method. Example: class Foo { public function bar($flag = true) {
}
}

#### The method union has a boolean flag argument $all, which is a certain sign of a Single Responsibility Principle violation. Open  public function union($sql, $all = false) Found in framework/db/Query.php by phpmd Since: PHPMD 1.4.0 A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method. Example: class Foo { public function bar($flag = true) {
}
}

#### Avoid unused parameters such as '$builder'. Open  public function prepare($builder)
Found in framework/db/Query.php by phpmd

Since: PHPMD 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example:

class Foo
{
private function bar($howdy) { //$howdy is not used
}
}