# yiisoft/yii2

framework/db/oci/Schema.php

### Summary

D
2 days

#### The class Schema has an overall complexity of 89 which is very high. The configured complexity threshold is 50. Open

class Schema extends \yii\db\Schema implements ConstraintFinderInterface
{
use ConstraintFinderTrait;

/**
Found in framework/db/oci/Schema.php by phpmd

Since: PHPMD 0.2.5

The Weighted Method Count (WMC) of a class is a good indicator of how much time and effort is required to modify and maintain this class. The WMC metric is defined as the sum of complexities of all methods declared in a class. A large number of methods also means that this class has a greater potential impact on derived classes.

Example:

class Foo {
public function bar() {
if ($a ==$b)  {
if ($a1 ==$b1) {
fiddle();
} elseif ($a2 ==$b2) {
fiddle();
} else {
}
}
}
public function baz() {
if ($a ==$b) {
if ($a1 ==$b1) {
fiddle();
} elseif ($a2 ==$b2) {
fiddle();
} else {
}
}
}
// Several other complex methods
}

{
$sql = <<<'SQL' SELECT /*+ PUSH_PRED(C) PUSH_PRED(D) PUSH_PRED(E) */ Found in framework/db/oci/Schema.php - About 1 hr to fix # Cognitive Complexity Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend. ### A method's cognitive complexity is based on a few simple rules: • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one • Code is considered more complex for each "break in the linear flow of the code" • Code is considered more complex when "flow breaking structures are nested" ### Further reading #### Function extractColumnType has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring. Open  protected function extractColumnType($column, $dbType,$precision, $scale,$length)
{
$column->dbType =$dbType;

if (strpos($dbType, 'FLOAT') !== false || strpos($dbType, 'DOUBLE') !== false) {
Found in framework/db/oci/Schema.php - About 1 hr to fix

# Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

### A method's cognitive complexity is based on a few simple rules:

• Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
• Code is considered more complex for each "break in the linear flow of the code"
• Code is considered more complex when "flow breaking structures are nested"

#### Function insert has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring. Open

    public function insert($table,$columns)
{
$params = [];$returnParams = [];
$sql =$this->db->getQueryBuilder()->insert($table,$columns, $params); Found in framework/db/oci/Schema.php - About 1 hr to fix # Cognitive Complexity Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend. ### A method's cognitive complexity is based on a few simple rules: • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one • Code is considered more complex for each "break in the linear flow of the code" • Code is considered more complex when "flow breaking structures are nested" ### Further reading #### Function loadTableConstraints has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring. Open  private function loadTableConstraints($tableName, $returnType) { static$sql = <<<'SQL'
SELECT
/*+ PUSH_PRED("uc") PUSH_PRED("uccol") PUSH_PRED("fuc") */
Found in framework/db/oci/Schema.php - About 55 mins to fix

# Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

### A method's cognitive complexity is based on a few simple rules:

• Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
• Code is considered more complex for each "break in the linear flow of the code"
• Code is considered more complex when "flow breaking structures are nested"

    protected function extractColumnSize($column,$dbType, $precision,$scale, $length) Found in framework/db/oci/Schema.php - About 35 mins to fix #### Method extractColumnType has 5 arguments (exceeds 4 allowed). Consider refactoring. Open  protected function extractColumnType($column, $dbType,$precision, $scale,$length)
Found in framework/db/oci/Schema.php - About 35 mins to fix

#### The method extractColumnType() has a Cyclomatic Complexity of 10. The configured cyclomatic complexity threshold is 10. Open

    protected function extractColumnType($column,$dbType, $precision,$scale, $length) {$column->dbType = $dbType; if (strpos($dbType, 'FLOAT') !== false || strpos($dbType, 'DOUBLE') !== false) { Found in framework/db/oci/Schema.php by phpmd Since: PHPMD 0.1 Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity. Example: // Cyclomatic Complexity = 11 class Foo { 1 public function example() { 2 if ($a == $b) { 3 if ($a1 == $b1) { fiddle(); 4 } elseif ($a2 == $b2) { fiddle(); } else { fiddle(); } 5 } elseif ($c == $d) { 6 while ($c == $d) { fiddle(); } 7 } elseif ($e == $f) { 8 for ($n = 0; $n <$h; $n++) { fiddle(); } } else { switch ($z) {
9               case 1:
fiddle();
break;
10              case 2:
fiddle();
break;
11              case 3:
fiddle();
break;
default:
fiddle();
break;
}
}
}
}

#### The method createColumn() has a Cyclomatic Complexity of 10. The configured cyclomatic complexity threshold is 10. Open

    protected function createColumn($column) {$c = $this->createColumnSchema();$c->name = $column['COLUMN_NAME'];$c->allowNull = $column['NULLABLE'] === 'Y'; Found in framework/db/oci/Schema.php by phpmd Since: PHPMD 0.1 Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity. Example: // Cyclomatic Complexity = 11 class Foo { 1 public function example() { 2 if ($a == $b) { 3 if ($a1 == $b1) { fiddle(); 4 } elseif ($a2 == $b2) { fiddle(); } else { fiddle(); } 5 } elseif ($c == $d) { 6 while ($c == $d) { fiddle(); } 7 } elseif ($e == $f) { 8 for ($n = 0; $n <$h; $n++) { fiddle(); } } else { switch ($z) {
9               case 1:
fiddle();
break;
10              case 2:
fiddle();
break;
11              case 3:
fiddle();
break;
default:
fiddle();
break;
}
}
}
}

#### The class Schema has a coupling between objects value of 15. Consider to reduce the number of dependencies under 13. Open

class Schema extends \yii\db\Schema implements ConstraintFinderInterface
{
use ConstraintFinderTrait;

/**
Found in framework/db/oci/Schema.php by phpmd

Since: PHPMD 1.1.0

A class with too many dependencies has negative impacts on several quality aspects of a class. This includes quality criteria like stability, maintainability and understandability

Example:

class Foo {
/**
* @var \foo\bar\X
*/
private $x = null; /** * @var \foo\bar\Y */ private$y = null;

/**
* @var \foo\bar\Z
*/
private $z = null; public function setFoo(\Foo$foo) {}
public function setBar(\Bar $bar) {} public function setBaz(\Baz$baz) {}

/**
* @return \SplObjectStorage
* @throws \OutOfRangeException
* @throws \InvalidArgumentException
* @throws \ErrorException
*/
public function process(\Iterator $it) {} // ... } #### Avoid unused parameters such as '$dbType'. Open

    protected function extractColumnSize($column,$dbType, $precision,$scale, $length) Found in framework/db/oci/Schema.php by phpmd Since: PHPMD 0.2 Avoid passing parameters to methods or constructors and then not using those parameters. Example: class Foo { private function bar($howdy)
{
// $howdy is not used } } #### Avoid unused parameters such as '$precision'. Open

    protected function extractColumnType($column,$dbType, $precision,$scale, $length) Found in framework/db/oci/Schema.php by phpmd Since: PHPMD 0.2 Avoid passing parameters to methods or constructors and then not using those parameters. Example: class Foo { private function bar($howdy)
{
// $howdy is not used } } #### Avoid unused parameters such as '$length'. Open

    protected function extractColumnType($column,$dbType, $precision,$scale, $length) Found in framework/db/oci/Schema.php by phpmd Since: PHPMD 0.2 Avoid passing parameters to methods or constructors and then not using those parameters. Example: class Foo { private function bar($howdy)
{
{
static $sql = <<<'SQL' SELECT /*+ PUSH_PRED("ui") PUSH_PRED("uicol") PUSH_PRED("uc") */ Found in framework/db/oci/Schema.php and 1 other location - About 6 hrs to fix framework/db/pgsql/Schema.php on lines 219..258 ## Duplicated Code Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states: Every piece of knowledge must have a single, unambiguous, authoritative representation within a system. When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways). ## Tuning This issue has a mass of 174. We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines. The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison. If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language. See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml. ## Refactorings ## Further Reading #### Similar blocks of code found in 3 locations. Consider refactoring. Open  protected function resolveTableName($name)
{
$resolvedName = new TableSchema();$parts = explode('.', str_replace('"', '', $name)); if (isset($parts[1])) {
Found in framework/db/oci/Schema.php and 2 other locations - About 3 hrs to fix
framework/db/mysql/Schema.php on lines 89..102
framework/db/pgsql/Schema.php on lines 137..150

## Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

## Tuning

This issue has a mass of 129.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.