yiisoft/yii2

View on GitHub
framework/helpers/BaseConsole.php

Summary

Maintainability
C
1 day
Test Coverage

The class BaseConsole has 48 public methods. Consider refactoring BaseConsole to keep number of public methods under 10.
Open

class BaseConsole
{
    // foreground color control codes
    const FG_BLACK = 30;
    const FG_RED = 31;
Severity: Minor
Found in framework/helpers/BaseConsole.php by phpmd

TooManyPublicMethods

Since: 0.1

A class with too many public methods is probably a good suspect for refactoring, in order to reduce its complexity and find a way to have more fine grained objects.

By default it ignores methods starting with 'get' or 'set'.

Example

Source https://phpmd.org/rules/codesize.html#toomanypublicmethods

The class BaseConsole has 50 non-getter- and setter-methods. Consider refactoring BaseConsole to keep number of methods under 25.
Open

class BaseConsole
{
    // foreground color control codes
    const FG_BLACK = 30;
    const FG_RED = 31;
Severity: Minor
Found in framework/helpers/BaseConsole.php by phpmd

TooManyMethods

Since: 0.1

A class with too many methods is probably a good suspect for refactoring, in order to reduce its complexity and find a way to have more fine grained objects.

By default it ignores methods starting with 'get' or 'set'.

The default was changed from 10 to 25 in PHPMD 2.3.

Example

Source https://phpmd.org/rules/codesize.html#toomanymethods

The class BaseConsole has an overall complexity of 151 which is very high. The configured complexity threshold is 50.
Open

class BaseConsole
{
    // foreground color control codes
    const FG_BLACK = 30;
    const FG_RED = 31;
Severity: Minor
Found in framework/helpers/BaseConsole.php by phpmd

Function ansiColorizedSubstr has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
Open

    public static function ansiColorizedSubstr($string, $start, $length)
    {
        if ($start < 0 || $length <= 0) {
            return '';
        }
Severity: Minor
Found in framework/helpers/BaseConsole.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function getScreenSize has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
Open

    public static function getScreenSize($refresh = false)
    {
        static $size;
        if ($size !== null && !$refresh) {
            return $size;
Severity: Minor
Found in framework/helpers/BaseConsole.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

The class BaseConsole has 50 public methods and attributes. Consider reducing the number of public items to less than 45.
Open

class BaseConsole
{
    // foreground color control codes
    const FG_BLACK = 30;
    const FG_RED = 31;
Severity: Minor
Found in framework/helpers/BaseConsole.php by phpmd

ExcessivePublicCount

Since: 0.1

A large number of public methods and attributes declared in a class can indicate the class may need to be broken up as increased effort will be required to thoroughly test it.

Example

public class Foo {
    public $value;
    public $something;
    public $var;
    // [... more more public attributes ...]

    public function doWork() {}
    public function doMoreWork() {}
    public function doWorkAgain() {}
    // [... more more public methods ...]
}

Source https://phpmd.org/rules/codesize.html#excessivepubliccount

Function prompt has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

    public static function prompt($text, $options = [])
    {
        $options = ArrayHelper::merge(
            [
                'required' => false,
Severity: Minor
Found in framework/helpers/BaseConsole.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function updateProgress has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

    public static function updateProgress($done, $total, $prefix = null)
    {
        if ($prefix === null) {
            $prefix = self::$_progressPrefix;
        } else {
Severity: Minor
Found in framework/helpers/BaseConsole.php - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function confirm has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    public static function confirm($message, $default = false)
    {
        while (true) {
            static::stdout($message . ' (yes|no) [' . ($default ? 'yes' : 'no') . ']:');
            $input = trim(static::stdin());
Severity: Minor
Found in framework/helpers/BaseConsole.php - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this method.
Open

                return $size = [$width, $height];
Severity: Major
Found in framework/helpers/BaseConsole.php - About 30 mins to fix

    Avoid too many return statements within this method.
    Open

            return $size = false;
    Severity: Major
    Found in framework/helpers/BaseConsole.php - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

                      return $size = [$width, $height];
      Severity: Major
      Found in framework/helpers/BaseConsole.php - About 30 mins to fix

        Function select has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            public static function select($prompt, $options = [])
            {
                top:
                static::stdout("$prompt [" . implode(',', array_keys($options)) . ',?]: ');
                $input = static::stdin();
        Severity: Minor
        Found in framework/helpers/BaseConsole.php - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function wrapText has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            public static function wrapText($text, $indent = 0, $refresh = false)
            {
                $size = static::getScreenSize($refresh);
                if ($size === false || $size[0] <= $indent) {
                    return $text;
        Severity: Minor
        Found in framework/helpers/BaseConsole.php - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        The method ansiToHtml() has 100 lines of code. Current threshold is set to 100. Avoid really long methods.
        Open

            public static function ansiToHtml($string, $styleMap = [])
            {
                $styleMap = [
                    // http://www.w3.org/TR/CSS2/syndata.html#value-def-color
                    self::FG_BLACK => ['color' => 'black'],
        Severity: Minor
        Found in framework/helpers/BaseConsole.php by phpmd

        The class BaseConsole has 1174 lines of code. Current threshold is 1000. Avoid really long classes.
        Open

        class BaseConsole
        {
            // foreground color control codes
            const FG_BLACK = 30;
            const FG_RED = 31;
        Severity: Minor
        Found in framework/helpers/BaseConsole.php by phpmd

        The method ansiToHtml() has an NPath complexity of 6120. The configured NPath complexity threshold is 200.
        Open

            public static function ansiToHtml($string, $styleMap = [])
            {
                $styleMap = [
                    // http://www.w3.org/TR/CSS2/syndata.html#value-def-color
                    self::FG_BLACK => ['color' => 'black'],
        Severity: Minor
        Found in framework/helpers/BaseConsole.php by phpmd

        NPathComplexity

        Since: 0.1

        The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

        Example

        class Foo {
            function bar() {
                // lots of complicated code
            }
        }

        Source https://phpmd.org/rules/codesize.html#npathcomplexity

        The method prompt() has a Cyclomatic Complexity of 10. The configured cyclomatic complexity threshold is 10.
        Open

            public static function prompt($text, $options = [])
            {
                $options = ArrayHelper::merge(
                    [
                        'required' => false,
        Severity: Minor
        Found in framework/helpers/BaseConsole.php by phpmd

        CyclomaticComplexity

        Since: 0.1

        Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

        Example

        // Cyclomatic Complexity = 11
        class Foo {
        1   public function example() {
        2       if ($a == $b) {
        3           if ($a1 == $b1) {
                        fiddle();
        4           } elseif ($a2 == $b2) {
                        fiddle();
                    } else {
                        fiddle();
                    }
        5       } elseif ($c == $d) {
        6           while ($c == $d) {
                        fiddle();
                    }
        7        } elseif ($e == $f) {
        8           for ($n = 0; $n < $h; $n++) {
                        fiddle();
                    }
                } else {
                    switch ($z) {
        9               case 1:
                            fiddle();
                            break;
        10              case 2:
                            fiddle();
                            break;
        11              case 3:
                            fiddle();
                            break;
                        default:
                            fiddle();
                            break;
                    }
                }
            }
        }

        Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

        The method ansiToHtml() has a Cyclomatic Complexity of 17. The configured cyclomatic complexity threshold is 10.
        Open

            public static function ansiToHtml($string, $styleMap = [])
            {
                $styleMap = [
                    // http://www.w3.org/TR/CSS2/syndata.html#value-def-color
                    self::FG_BLACK => ['color' => 'black'],
        Severity: Minor
        Found in framework/helpers/BaseConsole.php by phpmd

        CyclomaticComplexity

        Since: 0.1

        Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

        Example

        // Cyclomatic Complexity = 11
        class Foo {
        1   public function example() {
        2       if ($a == $b) {
        3           if ($a1 == $b1) {
                        fiddle();
        4           } elseif ($a2 == $b2) {
                        fiddle();
                    } else {
                        fiddle();
                    }
        5       } elseif ($c == $d) {
        6           while ($c == $d) {
                        fiddle();
                    }
        7        } elseif ($e == $f) {
        8           for ($n = 0; $n < $h; $n++) {
                        fiddle();
                    }
                } else {
                    switch ($z) {
        9               case 1:
                            fiddle();
                            break;
        10              case 2:
                            fiddle();
                            break;
        11              case 3:
                            fiddle();
                            break;
                        default:
                            fiddle();
                            break;
                    }
                }
            }
        }

        Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

        The method ansiColorizedSubstr() has a Cyclomatic Complexity of 12. The configured cyclomatic complexity threshold is 10.
        Open

            public static function ansiColorizedSubstr($string, $start, $length)
            {
                if ($start < 0 || $length <= 0) {
                    return '';
                }
        Severity: Minor
        Found in framework/helpers/BaseConsole.php by phpmd

        CyclomaticComplexity

        Since: 0.1

        Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

        Example

        // Cyclomatic Complexity = 11
        class Foo {
        1   public function example() {
        2       if ($a == $b) {
        3           if ($a1 == $b1) {
                        fiddle();
        4           } elseif ($a2 == $b2) {
                        fiddle();
                    } else {
                        fiddle();
                    }
        5       } elseif ($c == $d) {
        6           while ($c == $d) {
                        fiddle();
                    }
        7        } elseif ($e == $f) {
        8           for ($n = 0; $n < $h; $n++) {
                        fiddle();
                    }
                } else {
                    switch ($z) {
        9               case 1:
                            fiddle();
                            break;
        10              case 2:
                            fiddle();
                            break;
        11              case 3:
                            fiddle();
                            break;
                        default:
                            fiddle();
                            break;
                    }
                }
            }
        }

        Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

        The method getScreenSize() has a Cyclomatic Complexity of 13. The configured cyclomatic complexity threshold is 10.
        Open

            public static function getScreenSize($refresh = false)
            {
                static $size;
                if ($size !== null && !$refresh) {
                    return $size;
        Severity: Minor
        Found in framework/helpers/BaseConsole.php by phpmd

        CyclomaticComplexity

        Since: 0.1

        Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

        Example

        // Cyclomatic Complexity = 11
        class Foo {
        1   public function example() {
        2       if ($a == $b) {
        3           if ($a1 == $b1) {
                        fiddle();
        4           } elseif ($a2 == $b2) {
                        fiddle();
                    } else {
                        fiddle();
                    }
        5       } elseif ($c == $d) {
        6           while ($c == $d) {
                        fiddle();
                    }
        7        } elseif ($e == $f) {
        8           for ($n = 0; $n < $h; $n++) {
                        fiddle();
                    }
                } else {
                    switch ($z) {
        9               case 1:
                            fiddle();
                            break;
        10              case 2:
                            fiddle();
                            break;
        11              case 3:
                            fiddle();
                            break;
                        default:
                            fiddle();
                            break;
                    }
                }
            }
        }

        Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

        The method endProgress has a boolean flag argument $keepPrefix, which is a certain sign of a Single Responsibility Principle violation.
        Open

            public static function endProgress($remove = false, $keepPrefix = true)
        Severity: Minor
        Found in framework/helpers/BaseConsole.php by phpmd

        BooleanArgumentFlag

        Since: 1.4.0

        A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

        Example

        class Foo {
            public function bar($flag = true) {
            }
        }

        Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

        Remove error control operator '@' on line 662.
        Open

            public static function streamSupportsAnsiColors($stream)
            {
                return DIRECTORY_SEPARATOR === '\\'
                    ? getenv('ANSICON') !== false || getenv('ConEmuANSI') === 'ON'
                    : function_exists('posix_isatty') && @posix_isatty($stream);
        Severity: Minor
        Found in framework/helpers/BaseConsole.php by phpmd

        ErrorControlOperator

        Error suppression should be avoided if possible as it doesn't just suppress the error, that you are trying to stop, but will also suppress errors that you didn't predict would ever occur. Consider changing error_reporting() level and/or setting up your own error handler.

        Example

        function foo($filePath) {
            $file = @fopen($filPath); // hides exceptions
            $key = @$array[$notExistingKey]; // assigns null to $key
        }

        Source http://phpmd.org/rules/cleancode.html#errorcontroloperator

        The method confirm has a boolean flag argument $default, which is a certain sign of a Single Responsibility Principle violation.
        Open

            public static function confirm($message, $default = false)
        Severity: Minor
        Found in framework/helpers/BaseConsole.php by phpmd

        BooleanArgumentFlag

        Since: 1.4.0

        A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

        Example

        class Foo {
            public function bar($flag = true) {
            }
        }

        Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

        The method wrapText has a boolean flag argument $refresh, which is a certain sign of a Single Responsibility Principle violation.
        Open

            public static function wrapText($text, $indent = 0, $refresh = false)
        Severity: Minor
        Found in framework/helpers/BaseConsole.php by phpmd

        BooleanArgumentFlag

        Since: 1.4.0

        A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

        Example

        class Foo {
            public function bar($flag = true) {
            }
        }

        Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

        The method renderColoredString has a boolean flag argument $colored, which is a certain sign of a Single Responsibility Principle violation.
        Open

            public static function renderColoredString($string, $colored = true)
        Severity: Minor
        Found in framework/helpers/BaseConsole.php by phpmd

        BooleanArgumentFlag

        Since: 1.4.0

        A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

        Example

        class Foo {
            public function bar($flag = true) {
            }
        }

        Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

        The method getScreenSize has a boolean flag argument $refresh, which is a certain sign of a Single Responsibility Principle violation.
        Open

            public static function getScreenSize($refresh = false)
        Severity: Minor
        Found in framework/helpers/BaseConsole.php by phpmd

        BooleanArgumentFlag

        Since: 1.4.0

        A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

        Example

        class Foo {
            public function bar($flag = true) {
            }
        }

        Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

        The method endProgress has a boolean flag argument $remove, which is a certain sign of a Single Responsibility Principle violation.
        Open

            public static function endProgress($remove = false, $keepPrefix = true)
        Severity: Minor
        Found in framework/helpers/BaseConsole.php by phpmd

        BooleanArgumentFlag

        Since: 1.4.0

        A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

        Example

        class Foo {
            public function bar($flag = true) {
            }
        }

        Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

        The method stdin has a boolean flag argument $raw, which is a certain sign of a Single Responsibility Principle violation.
        Open

            public static function stdin($raw = false)
        Severity: Minor
        Found in framework/helpers/BaseConsole.php by phpmd

        BooleanArgumentFlag

        Since: 1.4.0

        A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

        Example

        class Foo {
            public function bar($flag = true) {
            }
        }

        Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

        Avoid assigning values to variables in if clauses and the like (line '719', column '18').
        Open

            public static function getScreenSize($refresh = false)
            {
                static $size;
                if ($size !== null && !$refresh) {
                    return $size;
        Severity: Minor
        Found in framework/helpers/BaseConsole.php by phpmd

        IfStatementAssignment

        Since: 2.7.0

        Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

        Example

        class Foo
        {
            public function bar($flag)
            {
                if ($foo = 'bar') { // possible typo
                    // ...
                }
                if ($baz = 0) { // always false
                    // ...
                }
            }
        }

        Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

        The method prompt() utilizes a goto statement.
        Open

                        goto top;
        Severity: Minor
        Found in framework/helpers/BaseConsole.php by phpmd

        GotoStatement

        Since: 1.1.0

        Goto makes code harder to read and it is nearly impossible to understand the control flow of an application that uses this language construct. Therefore it should be avoided. Consider to replace Goto with regular control structures and separate methods/function, which are easier to read.

        Example

        class Foo {
            public function bar($param)  {
                A:
                if ($param === 42) {
                    goto X;
                }
                Y:
                if (time() % 42 === 23) {
                    goto Z;
                }
                X:
                if (time() % 23 === 42) {
                    goto Y;
                }
                Z:
                return 42;
            }
        }

        Source https://phpmd.org/rules/design.html#gotostatement

        Avoid assigning values to variables in if clauses and the like (line '724', column '18').
        Open

            public static function getScreenSize($refresh = false)
            {
                static $size;
                if ($size !== null && !$refresh) {
                    return $size;
        Severity: Minor
        Found in framework/helpers/BaseConsole.php by phpmd

        IfStatementAssignment

        Since: 2.7.0

        Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

        Example

        class Foo
        {
            public function bar($flag)
            {
                if ($foo = 'bar') { // possible typo
                    // ...
                }
                if ($baz = 0) { // always false
                    // ...
                }
            }
        }

        Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

        The method select() utilizes a goto statement.
        Open

                    goto top;
        Severity: Minor
        Found in framework/helpers/BaseConsole.php by phpmd

        GotoStatement

        Since: 1.1.0

        Goto makes code harder to read and it is nearly impossible to understand the control flow of an application that uses this language construct. Therefore it should be avoided. Consider to replace Goto with regular control structures and separate methods/function, which are easier to read.

        Example

        class Foo {
            public function bar($param)  {
                A:
                if ($param === 42) {
                    goto X;
                }
                Y:
                if (time() % 42 === 23) {
                    goto Z;
                }
                X:
                if (time() % 23 === 42) {
                    goto Y;
                }
                Z:
                return 42;
            }
        }

        Source https://phpmd.org/rules/design.html#gotostatement

        The method prompt() utilizes a goto statement.
        Open

                    goto top;
        Severity: Minor
        Found in framework/helpers/BaseConsole.php by phpmd

        GotoStatement

        Since: 1.1.0

        Goto makes code harder to read and it is nearly impossible to understand the control flow of an application that uses this language construct. Therefore it should be avoided. Consider to replace Goto with regular control structures and separate methods/function, which are easier to read.

        Example

        class Foo {
            public function bar($param)  {
                A:
                if ($param === 42) {
                    goto X;
                }
                Y:
                if (time() % 42 === 23) {
                    goto Z;
                }
                X:
                if (time() % 23 === 42) {
                    goto Y;
                }
                Z:
                return 42;
            }
        }

        Source https://phpmd.org/rules/design.html#gotostatement

        The method select() utilizes a goto statement.
        Open

                    goto top;
        Severity: Minor
        Found in framework/helpers/BaseConsole.php by phpmd

        GotoStatement

        Since: 1.1.0

        Goto makes code harder to read and it is nearly impossible to understand the control flow of an application that uses this language construct. Therefore it should be avoided. Consider to replace Goto with regular control structures and separate methods/function, which are easier to read.

        Example

        class Foo {
            public function bar($param)  {
                A:
                if ($param === 42) {
                    goto X;
                }
                Y:
                if (time() % 42 === 23) {
                    goto Z;
                }
                X:
                if (time() % 23 === 42) {
                    goto Y;
                }
                Z:
                return 42;
            }
        }

        Source https://phpmd.org/rules/design.html#gotostatement

        The method prompt() utilizes a goto statement.
        Open

                    goto top;
        Severity: Minor
        Found in framework/helpers/BaseConsole.php by phpmd

        GotoStatement

        Since: 1.1.0

        Goto makes code harder to read and it is nearly impossible to understand the control flow of an application that uses this language construct. Therefore it should be avoided. Consider to replace Goto with regular control structures and separate methods/function, which are easier to read.

        Example

        class Foo {
            public function bar($param)  {
                A:
                if ($param === 42) {
                    goto X;
                }
                Y:
                if (time() % 42 === 23) {
                    goto Z;
                }
                X:
                if (time() % 23 === 42) {
                    goto Y;
                }
                Z:
                return 42;
            }
        }

        Source https://phpmd.org/rules/design.html#gotostatement

        Avoid assigning values to variables in if clauses and the like (line '719', column '65').
        Open

            public static function getScreenSize($refresh = false)
            {
                static $size;
                if ($size !== null && !$refresh) {
                    return $size;
        Severity: Minor
        Found in framework/helpers/BaseConsole.php by phpmd

        IfStatementAssignment

        Since: 2.7.0

        Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

        Example

        class Foo
        {
            public function bar($flag)
            {
                if ($foo = 'bar') { // possible typo
                    // ...
                }
                if ($baz = 0) { // always false
                    // ...
                }
            }
        }

        Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

        Avoid assigning values to variables in if clauses and the like (line '724', column '60').
        Open

            public static function getScreenSize($refresh = false)
            {
                static $size;
                if ($size !== null && !$refresh) {
                    return $size;
        Severity: Minor
        Found in framework/helpers/BaseConsole.php by phpmd

        IfStatementAssignment

        Since: 2.7.0

        Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

        Example

        class Foo
        {
            public function bar($flag)
            {
                if ($foo = 'bar') { // possible typo
                    // ...
                }
                if ($baz = 0) { // always false
                    // ...
                }
            }
        }

        Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

        TODO found
        Open

                // TODO rework/refactor according to https://github.com/yiisoft/yii2/issues/746
        Severity: Minor
        Found in framework/helpers/BaseConsole.php by fixme

        TODO found
        Open

                // TODO rework/refactor according to https://github.com/yiisoft/yii2/issues/746
        Severity: Minor
        Found in framework/helpers/BaseConsole.php by fixme

        There are no issues that match your filters.

        Category
        Status