yiisoft/yii2

View on GitHub
framework/helpers/BaseFormatConverter.php

Summary

Maintainability
D
2 days
Test Coverage

Function convertDateIcuToPhp has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

    public static function convertDateIcuToPhp($pattern, $type = 'date', $locale = null)
    {
        if (isset(self::$_icuShortFormats[$pattern])) {
            if (extension_loaded('intl')) {
                if ($locale === null) {
Severity: Minor
Found in framework/helpers/BaseFormatConverter.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function convertDateIcuToJui has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

    public static function convertDateIcuToJui($pattern, $type = 'date', $locale = null)
    {
        if (isset(self::$_icuShortFormats[$pattern])) {
            if (extension_loaded('intl')) {
                if ($locale === null) {
Severity: Minor
Found in framework/helpers/BaseFormatConverter.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

The method convertDateIcuToPhp() has 132 lines of code. Current threshold is set to 100. Avoid really long methods.
Open

    public static function convertDateIcuToPhp($pattern, $type = 'date', $locale = null)
    {
        if (isset(self::$_icuShortFormats[$pattern])) {
            if (extension_loaded('intl')) {
                if ($locale === null) {

The method convertDateIcuToJui() has 130 lines of code. Current threshold is set to 100. Avoid really long methods.
Open

    public static function convertDateIcuToJui($pattern, $type = 'date', $locale = null)
    {
        if (isset(self::$_icuShortFormats[$pattern])) {
            if (extension_loaded('intl')) {
                if ($locale === null) {

XXX found
Open

            'XXX' => 'P, \Z',    // Time Zone: ISO8601 extended hm, with Z, e.g. -08:00, Z

XXX found
Open

            'XXX' => '',    // Time Zone: ISO8601 extended hm, with Z, e.g. -08:00, Z

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        if (isset(self::$_icuShortFormats[$pattern])) {
            if (extension_loaded('intl')) {
                if ($locale === null) {
                    $locale = Yii::$app->language;
                }
Severity: Major
Found in framework/helpers/BaseFormatConverter.php and 1 other location - About 6 hrs to fix
framework/helpers/BaseFormatConverter.php on lines 105..121

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 181.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        if (isset(self::$_icuShortFormats[$pattern])) {
            if (extension_loaded('intl')) {
                if ($locale === null) {
                    $locale = Yii::$app->language;
                }
Severity: Major
Found in framework/helpers/BaseFormatConverter.php and 1 other location - About 6 hrs to fix
framework/helpers/BaseFormatConverter.php on lines 362..378

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 181.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public static $phpFallbackDatePatterns = [
        'short' => [
            'date' => 'n/j/y',
            'time' => 'H:i',
            'datetime' => 'n/j/y H:i',
Severity: Major
Found in framework/helpers/BaseFormatConverter.php and 1 other location - About 1 hr to fix
framework/helpers/BaseFormatConverter.php on lines 54..75

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 90.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public static $juiFallbackDatePatterns = [
        'short' => [
            'date' => 'd/m/y',
            'time' => '',
            'datetime' => 'd/m/y',
Severity: Major
Found in framework/helpers/BaseFormatConverter.php and 1 other location - About 1 hr to fix
framework/helpers/BaseFormatConverter.php on lines 28..49

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 90.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

The variable $_icuShortFormats is not named in camelCase.
Open

    public static function convertDateIcuToPhp($pattern, $type = 'date', $locale = null)
    {
        if (isset(self::$_icuShortFormats[$pattern])) {
            if (extension_loaded('intl')) {
                if ($locale === null) {

Since: PHPMD 0.2

It is considered best practice to use the camelCase notation to name variables.

Example:

class ClassName {
      public function doSomething() {
          $data_module = new DataModule();
      }
  }

Source: http://phpmd.org/rules/controversial.txt

The variable $_icuShortFormats is not named in camelCase.
Open

    public static function convertDateIcuToPhp($pattern, $type = 'date', $locale = null)
    {
        if (isset(self::$_icuShortFormats[$pattern])) {
            if (extension_loaded('intl')) {
                if ($locale === null) {

Since: PHPMD 0.2

It is considered best practice to use the camelCase notation to name variables.

Example:

class ClassName {
      public function doSomething() {
          $data_module = new DataModule();
      }
  }

Source: http://phpmd.org/rules/controversial.txt

The variable $_icuShortFormats is not named in camelCase.
Open

    public static function convertDateIcuToJui($pattern, $type = 'date', $locale = null)
    {
        if (isset(self::$_icuShortFormats[$pattern])) {
            if (extension_loaded('intl')) {
                if ($locale === null) {

Since: PHPMD 0.2

It is considered best practice to use the camelCase notation to name variables.

Example:

class ClassName {
      public function doSomething() {
          $data_module = new DataModule();
      }
  }

Source: http://phpmd.org/rules/controversial.txt

The variable $_icuShortFormats is not named in camelCase.
Open

    public static function convertDateIcuToJui($pattern, $type = 'date', $locale = null)
    {
        if (isset(self::$_icuShortFormats[$pattern])) {
            if (extension_loaded('intl')) {
                if ($locale === null) {

Since: PHPMD 0.2

It is considered best practice to use the camelCase notation to name variables.

Example:

class ClassName {
      public function doSomething() {
          $data_module = new DataModule();
      }
  }

Source: http://phpmd.org/rules/controversial.txt

The variable $_icuShortFormats is not named in camelCase.
Open

    public static function convertDateIcuToPhp($pattern, $type = 'date', $locale = null)
    {
        if (isset(self::$_icuShortFormats[$pattern])) {
            if (extension_loaded('intl')) {
                if ($locale === null) {

Since: PHPMD 0.2

It is considered best practice to use the camelCase notation to name variables.

Example:

class ClassName {
      public function doSomething() {
          $data_module = new DataModule();
      }
  }

Source: http://phpmd.org/rules/controversial.txt

The variable $_icuShortFormats is not named in camelCase.
Open

    public static function convertDateIcuToPhp($pattern, $type = 'date', $locale = null)
    {
        if (isset(self::$_icuShortFormats[$pattern])) {
            if (extension_loaded('intl')) {
                if ($locale === null) {

Since: PHPMD 0.2

It is considered best practice to use the camelCase notation to name variables.

Example:

class ClassName {
      public function doSomething() {
          $data_module = new DataModule();
      }
  }

Source: http://phpmd.org/rules/controversial.txt

The variable $_icuShortFormats is not named in camelCase.
Open

    public static function convertDateIcuToJui($pattern, $type = 'date', $locale = null)
    {
        if (isset(self::$_icuShortFormats[$pattern])) {
            if (extension_loaded('intl')) {
                if ($locale === null) {

Since: PHPMD 0.2

It is considered best practice to use the camelCase notation to name variables.

Example:

class ClassName {
      public function doSomething() {
          $data_module = new DataModule();
      }
  }

Source: http://phpmd.org/rules/controversial.txt

The variable $_icuShortFormats is not named in camelCase.
Open

    public static function convertDateIcuToJui($pattern, $type = 'date', $locale = null)
    {
        if (isset(self::$_icuShortFormats[$pattern])) {
            if (extension_loaded('intl')) {
                if ($locale === null) {

Since: PHPMD 0.2

It is considered best practice to use the camelCase notation to name variables.

Example:

class ClassName {
      public function doSomething() {
          $data_module = new DataModule();
      }
  }

Source: http://phpmd.org/rules/controversial.txt

The variable $_icuShortFormats is not named in camelCase.
Open

    public static function convertDateIcuToJui($pattern, $type = 'date', $locale = null)
    {
        if (isset(self::$_icuShortFormats[$pattern])) {
            if (extension_loaded('intl')) {
                if ($locale === null) {

Since: PHPMD 0.2

It is considered best practice to use the camelCase notation to name variables.

Example:

class ClassName {
      public function doSomething() {
          $data_module = new DataModule();
      }
  }

Source: http://phpmd.org/rules/controversial.txt

The variable $_icuShortFormats is not named in camelCase.
Open

    public static function convertDateIcuToPhp($pattern, $type = 'date', $locale = null)
    {
        if (isset(self::$_icuShortFormats[$pattern])) {
            if (extension_loaded('intl')) {
                if ($locale === null) {

Since: PHPMD 0.2

It is considered best practice to use the camelCase notation to name variables.

Example:

class ClassName {
      public function doSomething() {
          $data_module = new DataModule();
      }
  }

Source: http://phpmd.org/rules/controversial.txt

There are no issues that match your filters.

Category
Status