yiisoft/yii2

View on GitHub
framework/i18n/MessageFormatter.php

Summary

Maintainability
D
2 days
Test Coverage

Function parseToken has a Cognitive Complexity of 35 (exceeds 5 allowed). Consider refactoring.
Open

    private function parseToken($token, $args, $locale)
    {
        // parsing pattern based on ICU grammar:
        // http://icu-project.org/apiref/icu4c/classMessageFormat.html#details
        $charset = Yii::$app ? Yii::$app->charset : 'UTF-8';
Severity: Minor
Found in framework/i18n/MessageFormatter.php - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function replaceNamedArguments has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
Open

    private function replaceNamedArguments($pattern, $givenParams, &$resultingParams = [], &$map = [])
    {
        if (($tokens = self::tokenizePattern($pattern)) === false) {
            return false;
        }
Severity: Minor
Found in framework/i18n/MessageFormatter.php - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

The class MessageFormatter has an overall complexity of 92 which is very high. The configured complexity threshold is 50.
Open

class MessageFormatter extends Component
{
    private $_errorCode = 0;
    private $_errorMessage = '';

Severity: Minor
Found in framework/i18n/MessageFormatter.php by phpmd

Function tokenizePattern has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
Open

    private static function tokenizePattern($pattern)
    {
        $charset = Yii::$app ? Yii::$app->charset : 'UTF-8';
        $depth = 1;
        if (($start = $pos = mb_strpos($pattern, '{', 0, $charset)) === false) {
Severity: Minor
Found in framework/i18n/MessageFormatter.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function parse has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

    public function parse($pattern, $message, $language)
    {
        $this->_errorCode = 0;
        $this->_errorMessage = '';

Severity: Minor
Found in framework/i18n/MessageFormatter.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Consider simplifying this complex logical expression.
Open

                    if ($message === false && $selector === 'other' ||
                        strncmp($selector, '=', 1) === 0 && (int) mb_substr($selector, 1, mb_strlen($selector, $charset), $charset) === $arg ||
                        $selector === 'one' && $arg - $offset == 1
                    ) {
                        $message = implode(',', str_replace('#', $arg - $offset, $plural[$i]));
Severity: Major
Found in framework/i18n/MessageFormatter.php - About 40 mins to fix

    Function fallbackFormat has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        protected function fallbackFormat($pattern, $args, $locale)
        {
            if (($tokens = self::tokenizePattern($pattern)) === false) {
                $this->_errorCode = -1;
                $this->_errorMessage = 'Message pattern is invalid.';
    Severity: Minor
    Found in framework/i18n/MessageFormatter.php - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this method.
    Open

                            return false;
    Severity: Major
    Found in framework/i18n/MessageFormatter.php - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

              return false;
      Severity: Major
      Found in framework/i18n/MessageFormatter.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                return implode('', $tokens);
        Severity: Major
        Found in framework/i18n/MessageFormatter.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                                  return false;
          Severity: Major
          Found in framework/i18n/MessageFormatter.php - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                    return $result;
            Severity: Major
            Found in framework/i18n/MessageFormatter.php - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                                  return false;
              Severity: Major
              Found in framework/i18n/MessageFormatter.php - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                            return false;
                Severity: Major
                Found in framework/i18n/MessageFormatter.php - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                              return false;
                  Severity: Major
                  Found in framework/i18n/MessageFormatter.php - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Open

                                        return $this->fallbackFormat($message, $args, $locale);
                    Severity: Major
                    Found in framework/i18n/MessageFormatter.php - About 30 mins to fix

                      Avoid too many return statements within this method.
                      Open

                                          return $this->fallbackFormat($message, $args, $locale);
                      Severity: Major
                      Found in framework/i18n/MessageFormatter.php - About 30 mins to fix

                        Function format has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                        Open

                            public function format($pattern, $params, $language)
                            {
                                $this->_errorCode = 0;
                                $this->_errorMessage = '';
                        
                        
                        Severity: Minor
                        Found in framework/i18n/MessageFormatter.php - About 25 mins to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        The method tokenizePattern() has an NPath complexity of 776. The configured NPath complexity threshold is 200.
                        Open

                            private static function tokenizePattern($pattern)
                            {
                                $charset = Yii::$app ? Yii::$app->charset : 'UTF-8';
                                $depth = 1;
                                if (($start = $pos = mb_strpos($pattern, '{', 0, $charset)) === false) {
                        Severity: Minor
                        Found in framework/i18n/MessageFormatter.php by phpmd

                        NPathComplexity

                        Since: 0.1

                        The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

                        Example

                        class Foo {
                            function bar() {
                                // lots of complicated code
                            }
                        }

                        Source https://phpmd.org/rules/codesize.html#npathcomplexity

                        The method replaceNamedArguments() has an NPath complexity of 434. The configured NPath complexity threshold is 200.
                        Open

                            private function replaceNamedArguments($pattern, $givenParams, &$resultingParams = [], &$map = [])
                            {
                                if (($tokens = self::tokenizePattern($pattern)) === false) {
                                    return false;
                                }
                        Severity: Minor
                        Found in framework/i18n/MessageFormatter.php by phpmd

                        NPathComplexity

                        Since: 0.1

                        The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

                        Example

                        class Foo {
                            function bar() {
                                // lots of complicated code
                            }
                        }

                        Source https://phpmd.org/rules/codesize.html#npathcomplexity

                        The method parseToken() has an NPath complexity of 2624. The configured NPath complexity threshold is 200.
                        Open

                            private function parseToken($token, $args, $locale)
                            {
                                // parsing pattern based on ICU grammar:
                                // http://icu-project.org/apiref/icu4c/classMessageFormat.html#details
                                $charset = Yii::$app ? Yii::$app->charset : 'UTF-8';
                        Severity: Minor
                        Found in framework/i18n/MessageFormatter.php by phpmd

                        NPathComplexity

                        Since: 0.1

                        The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

                        Example

                        class Foo {
                            function bar() {
                                // lots of complicated code
                            }
                        }

                        Source https://phpmd.org/rules/codesize.html#npathcomplexity

                        The method replaceNamedArguments() has a Cyclomatic Complexity of 14. The configured cyclomatic complexity threshold is 10.
                        Open

                            private function replaceNamedArguments($pattern, $givenParams, &$resultingParams = [], &$map = [])
                            {
                                if (($tokens = self::tokenizePattern($pattern)) === false) {
                                    return false;
                                }
                        Severity: Minor
                        Found in framework/i18n/MessageFormatter.php by phpmd

                        CyclomaticComplexity

                        Since: 0.1

                        Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

                        Example

                        // Cyclomatic Complexity = 11
                        class Foo {
                        1   public function example() {
                        2       if ($a == $b) {
                        3           if ($a1 == $b1) {
                                        fiddle();
                        4           } elseif ($a2 == $b2) {
                                        fiddle();
                                    } else {
                                        fiddle();
                                    }
                        5       } elseif ($c == $d) {
                        6           while ($c == $d) {
                                        fiddle();
                                    }
                        7        } elseif ($e == $f) {
                        8           for ($n = 0; $n < $h; $n++) {
                                        fiddle();
                                    }
                                } else {
                                    switch ($z) {
                        9               case 1:
                                            fiddle();
                                            break;
                        10              case 2:
                                            fiddle();
                                            break;
                        11              case 3:
                                            fiddle();
                                            break;
                                        default:
                                            fiddle();
                                            break;
                                    }
                                }
                            }
                        }

                        Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

                        The method parseToken() has a Cyclomatic Complexity of 42. The configured cyclomatic complexity threshold is 10.
                        Open

                            private function parseToken($token, $args, $locale)
                            {
                                // parsing pattern based on ICU grammar:
                                // http://icu-project.org/apiref/icu4c/classMessageFormat.html#details
                                $charset = Yii::$app ? Yii::$app->charset : 'UTF-8';
                        Severity: Minor
                        Found in framework/i18n/MessageFormatter.php by phpmd

                        CyclomaticComplexity

                        Since: 0.1

                        Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

                        Example

                        // Cyclomatic Complexity = 11
                        class Foo {
                        1   public function example() {
                        2       if ($a == $b) {
                        3           if ($a1 == $b1) {
                                        fiddle();
                        4           } elseif ($a2 == $b2) {
                                        fiddle();
                                    } else {
                                        fiddle();
                                    }
                        5       } elseif ($c == $d) {
                        6           while ($c == $d) {
                                        fiddle();
                                    }
                        7        } elseif ($e == $f) {
                        8           for ($n = 0; $n < $h; $n++) {
                                        fiddle();
                                    }
                                } else {
                                    switch ($z) {
                        9               case 1:
                                            fiddle();
                                            break;
                        10              case 2:
                                            fiddle();
                                            break;
                        11              case 3:
                                            fiddle();
                                            break;
                                        default:
                                            fiddle();
                                            break;
                                    }
                                }
                            }
                        }

                        Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

                        The method tokenizePattern() has a Cyclomatic Complexity of 13. The configured cyclomatic complexity threshold is 10.
                        Open

                            private static function tokenizePattern($pattern)
                            {
                                $charset = Yii::$app ? Yii::$app->charset : 'UTF-8';
                                $depth = 1;
                                if (($start = $pos = mb_strpos($pattern, '{', 0, $charset)) === false) {
                        Severity: Minor
                        Found in framework/i18n/MessageFormatter.php by phpmd

                        CyclomaticComplexity

                        Since: 0.1

                        Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

                        Example

                        // Cyclomatic Complexity = 11
                        class Foo {
                        1   public function example() {
                        2       if ($a == $b) {
                        3           if ($a1 == $b1) {
                                        fiddle();
                        4           } elseif ($a2 == $b2) {
                                        fiddle();
                                    } else {
                                        fiddle();
                                    }
                        5       } elseif ($c == $d) {
                        6           while ($c == $d) {
                                        fiddle();
                                    }
                        7        } elseif ($e == $f) {
                        8           for ($n = 0; $n < $h; $n++) {
                                        fiddle();
                                    }
                                } else {
                                    switch ($z) {
                        9               case 1:
                                            fiddle();
                                            break;
                        10              case 2:
                                            fiddle();
                                            break;
                        11              case 3:
                                            fiddle();
                                            break;
                                        default:
                                            fiddle();
                                            break;
                                    }
                                }
                            }
                        }

                        Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

                        Missing class import via use statement (line '103', column '30').
                        Open

                                    $formatter = new \MessageFormatter($language, $pattern);
                        Severity: Minor
                        Found in framework/i18n/MessageFormatter.php by phpmd

                        MissingImport

                        Since: 2.7.0

                        Importing all external classes in a file through use statements makes them clearly visible.

                        Example

                        function make() {
                            return new \stdClass();
                        }

                        Source http://phpmd.org/rules/cleancode.html#MissingImport

                        Missing class import via use statement (line '177', column '26').
                        Open

                                $formatter = new \MessageFormatter($language, $pattern);
                        Severity: Minor
                        Found in framework/i18n/MessageFormatter.php by phpmd

                        MissingImport

                        Since: 2.7.0

                        Importing all external classes in a file through use statements makes them clearly visible.

                        Example

                        function make() {
                            return new \stdClass();
                        }

                        Source http://phpmd.org/rules/cleancode.html#MissingImport

                        Avoid assigning values to variables in if clauses and the like (line '274', column '22').
                        Open

                            protected function fallbackFormat($pattern, $args, $locale)
                            {
                                if (($tokens = self::tokenizePattern($pattern)) === false) {
                                    $this->_errorCode = -1;
                                    $this->_errorMessage = 'Message pattern is invalid.';
                        Severity: Minor
                        Found in framework/i18n/MessageFormatter.php by phpmd

                        IfStatementAssignment

                        Since: 2.7.0

                        Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

                        Example

                        class Foo
                        {
                            public function bar($flag)
                            {
                                if ($foo = 'bar') { // possible typo
                                    // ...
                                }
                                if ($baz = 0) { // always false
                                    // ...
                                }
                            }
                        }

                        Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

                        Avoid assigning values to variables in if clauses and the like (line '211', column '14').
                        Open

                            private function replaceNamedArguments($pattern, $givenParams, &$resultingParams = [], &$map = [])
                            {
                                if (($tokens = self::tokenizePattern($pattern)) === false) {
                                    return false;
                                }
                        Severity: Minor
                        Found in framework/i18n/MessageFormatter.php by phpmd

                        IfStatementAssignment

                        Since: 2.7.0

                        Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

                        Example

                        class Foo
                        {
                            public function bar($flag)
                            {
                                if ($foo = 'bar') { // possible typo
                                    // ...
                                }
                                if ($baz = 0) { // always false
                                    // ...
                                }
                            }
                        }

                        Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

                        Avoid assigning values to variables in if clauses and the like (line '295', column '14').
                        Open

                            private static function tokenizePattern($pattern)
                            {
                                $charset = Yii::$app ? Yii::$app->charset : 'UTF-8';
                                $depth = 1;
                                if (($start = $pos = mb_strpos($pattern, '{', 0, $charset)) === false) {
                        Severity: Minor
                        Found in framework/i18n/MessageFormatter.php by phpmd

                        IfStatementAssignment

                        Since: 2.7.0

                        Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

                        Example

                        class Foo
                        {
                            public function bar($flag)
                            {
                                if ($foo = 'bar') { // possible typo
                                    // ...
                                }
                                if ($baz = 0) { // always false
                                    // ...
                                }
                            }
                        }

                        Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

                        Avoid assigning values to variables in if clauses and the like (line '157', column '14').
                        Open

                            public function parse($pattern, $message, $language)
                            {
                                $this->_errorCode = 0;
                                $this->_errorMessage = '';
                        
                        
                        Severity: Minor
                        Found in framework/i18n/MessageFormatter.php by phpmd

                        IfStatementAssignment

                        Since: 2.7.0

                        Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

                        Example

                        class Foo
                        {
                            public function bar($flag)
                            {
                                if ($foo = 'bar') { // possible typo
                                    // ...
                                }
                                if ($baz = 0) { // always false
                                    // ...
                                }
                            }
                        }

                        Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

                        Avoid assigning values to variables in if clauses and the like (line '266', column '14').
                        Open

                            protected function fallbackFormat($pattern, $args, $locale)
                            {
                                if (($tokens = self::tokenizePattern($pattern)) === false) {
                                    $this->_errorCode = -1;
                                    $this->_errorMessage = 'Message pattern is invalid.';
                        Severity: Minor
                        Found in framework/i18n/MessageFormatter.php by phpmd

                        IfStatementAssignment

                        Since: 2.7.0

                        Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

                        Example

                        class Foo
                        {
                            public function bar($flag)
                            {
                                if ($foo = 'bar') { // possible typo
                                    // ...
                                }
                                if ($baz = 0) { // always false
                                    // ...
                                }
                            }
                        }

                        Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

                        Avoid assigning values to variables in if clauses and the like (line '295', column '23').
                        Open

                            private static function tokenizePattern($pattern)
                            {
                                $charset = Yii::$app ? Yii::$app->charset : 'UTF-8';
                                $depth = 1;
                                if (($start = $pos = mb_strpos($pattern, '{', 0, $charset)) === false) {
                        Severity: Minor
                        Found in framework/i18n/MessageFormatter.php by phpmd

                        IfStatementAssignment

                        Since: 2.7.0

                        Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

                        Example

                        class Foo
                        {
                            public function bar($flag)
                            {
                                if ($foo = 'bar') { // possible typo
                                    // ...
                                }
                                if ($baz = 0) { // always false
                                    // ...
                                }
                            }
                        }

                        Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

                        Avoid assigning values to variables in if clauses and the like (line '238', column '22').
                        Open

                            private function replaceNamedArguments($pattern, $givenParams, &$resultingParams = [], &$map = [])
                            {
                                if (($tokens = self::tokenizePattern($pattern)) === false) {
                                    return false;
                                }
                        Severity: Minor
                        Found in framework/i18n/MessageFormatter.php by phpmd

                        IfStatementAssignment

                        Since: 2.7.0

                        Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

                        Example

                        class Foo
                        {
                            public function bar($flag)
                            {
                                if ($foo = 'bar') { // possible typo
                                    // ...
                                }
                                if ($baz = 0) { // always false
                                    // ...
                                }
                            }
                        }

                        Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

                        Avoid assigning values to variables in if clauses and the like (line '366', column '46').
                        Open

                            private function parseToken($token, $args, $locale)
                            {
                                // parsing pattern based on ICU grammar:
                                // http://icu-project.org/apiref/icu4c/classMessageFormat.html#details
                                $charset = Yii::$app ? Yii::$app->charset : 'UTF-8';
                        Severity: Minor
                        Found in framework/i18n/MessageFormatter.php by phpmd

                        IfStatementAssignment

                        Since: 2.7.0

                        Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

                        Example

                        class Foo
                        {
                            public function bar($flag)
                            {
                                if ($foo = 'bar') { // possible typo
                                    // ...
                                }
                                if ($baz = 0) { // always false
                                    // ...
                                }
                            }
                        }

                        Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

                        There are no issues that match your filters.

                        Category
                        Status