yiisoft/yii2

View on GitHub
framework/web/UrlNormalizerRedirectException.php

Summary

Maintainability
A
45 mins
Test Coverage

Method __construct has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

    public function __construct($url, $statusCode = 302, $scheme = false, $message = null, $code = 0, \Exception $previous = null)
Severity: Minor
Found in framework/web/UrlNormalizerRedirectException.php - About 45 mins to fix

    The method __construct has a boolean flag argument $scheme, which is a certain sign of a Single Responsibility Principle violation.
    Open

        public function __construct($url, $statusCode = 302, $scheme = false, $message = null, $code = 0, \Exception $previous = null)

    Since: PHPMD 1.4.0

    A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

    Example:

    class Foo {
          public function bar($flag = true) {
          }
      }

    Source: http://phpmd.org/rules/cleancode.txt

    There are no issues that match your filters.

    Category
    Status