yiisoft/yii2

View on GitHub
framework/web/UrlRule.php

Summary

Maintainability
D
2 days
Test Coverage

Function createUrl has a Cognitive Complexity of 42 (exceeds 5 allowed). Consider refactoring.
Open

    public function createUrl($manager, $route, $params)
    {
        if ($this->mode === self::PARSING_ONLY) {
            $this->createStatus = self::CREATE_STATUS_PARSING_ONLY;
            return false;
Severity: Minor
Found in framework/web/UrlRule.php - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function translatePattern has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
Open

    private function translatePattern($allowAppendSlash)
    {
        $tr = [
            '.' => '\\.',
            '*' => '\\*',
Severity: Minor
Found in framework/web/UrlRule.php - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function parseRequest has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
Open

    public function parseRequest($manager, $request)
    {
        if ($this->mode === self::CREATION_ONLY) {
            return false;
        }
Severity: Minor
Found in framework/web/UrlRule.php - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

The class UrlRule has an overall complexity of 110 which is very high. The configured complexity threshold is 50.
Open

class UrlRule extends BaseObject implements UrlRuleInterface
{
    /**
     * Set [[mode]] with this value to mark that this rule is for URL parsing only.
     */
Severity: Minor
Found in framework/web/UrlRule.php by phpmd

Since: PHPMD 0.2.5

The Weighted Method Count (WMC) of a class is a good indicator of how much time and effort is required to modify and maintain this class. The WMC metric is defined as the sum of complexities of all methods declared in a class. A large number of methods also means that this class has a greater potential impact on derived classes.

Example:

class Foo {
      public function bar() {
          if ($a == $b)  {
              if ($a1 == $b1) {
                  fiddle();
              } elseif ($a2 == $b2) {
                  fiddle();
              } else {
              }
          }
      }
      public function baz() {
          if ($a == $b) {
              if ($a1 == $b1) {
                  fiddle();
              } elseif ($a2 == $b2) {
                  fiddle();
              } else {
              }
          }
      }
      // Several other complex methods
  }

Source: http://phpmd.org/rules/codesize.txt

Consider simplifying this complex logical expression.
Open

                    if (
                        $allowAppendSlash
                        && ($appendSlash || $offset === 1)
                        && (($offset - $oldOffset) === 1)
                        && isset($this->pattern[$offset + $length])
Severity: Critical
Found in framework/web/UrlRule.php - About 2 hrs to fix

    Function preparePattern has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
    Open

        private function preparePattern()
        {
            $this->pattern = $this->trimSlashes($this->pattern);
            $this->route = trim($this->route, '/');
    
    
    Severity: Minor
    Found in framework/web/UrlRule.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function init has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
    Open

        public function init()
        {
            if ($this->pattern === null) {
                throw new InvalidConfigException('UrlRule::pattern must be set.');
            }
    Severity: Minor
    Found in framework/web/UrlRule.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    The class UrlRule has 16 fields. Consider redesigning UrlRule to keep the number of fields under 15.
    Open

    class UrlRule extends BaseObject implements UrlRuleInterface
    {
        /**
         * Set [[mode]] with this value to mark that this rule is for URL parsing only.
         */
    Severity: Minor
    Found in framework/web/UrlRule.php by phpmd

    Since: PHPMD 0.1

    Classes that have too many fields could be redesigned to have fewer fields, possibly through some nested object grouping of some of the information. For example, a class with city/state/zip fields could instead have one Address field.

    Example:

    class Person {
         protected $one;
         private $two;
         private $three;
         [... many more fields ...]
      }

    Source: http://phpmd.org/rules/codesize.txt

    Avoid too many return statements within this method.
    Open

                return $this->getNormalizer($manager)->normalizeRoute([$route, $params]);
    Severity: Major
    Found in framework/web/UrlRule.php - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

              return [$route, $params];
      Severity: Major
      Found in framework/web/UrlRule.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                    return false;
        Severity: Major
        Found in framework/web/UrlRule.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                  return $url;
          Severity: Major
          Found in framework/web/UrlRule.php - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                            return false;
            Severity: Major
            Found in framework/web/UrlRule.php - About 30 mins to fix

              The method createUrl() has an NPath complexity of 149688. The configured NPath complexity threshold is 200.
              Open

                  public function createUrl($manager, $route, $params)
                  {
                      if ($this->mode === self::PARSING_ONLY) {
                          $this->createStatus = self::CREATE_STATUS_PARSING_ONLY;
                          return false;
              Severity: Minor
              Found in framework/web/UrlRule.php by phpmd

              Since: PHPMD 0.1

              The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

              Example:

              class Foo {
                    function bar() {
                        // lots of complicated code
                    }
                }

              Source: http://phpmd.org/rules/codesize.txt

              The method init() has an NPath complexity of 256. The configured NPath complexity threshold is 200.
              Open

                  public function init()
                  {
                      if ($this->pattern === null) {
                          throw new InvalidConfigException('UrlRule::pattern must be set.');
                      }
              Severity: Minor
              Found in framework/web/UrlRule.php by phpmd

              Since: PHPMD 0.1

              The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

              Example:

              class Foo {
                    function bar() {
                        // lots of complicated code
                    }
                }

              Source: http://phpmd.org/rules/codesize.txt

              The method translatePattern() has an NPath complexity of 960. The configured NPath complexity threshold is 200.
              Open

                  private function translatePattern($allowAppendSlash)
                  {
                      $tr = [
                          '.' => '\\.',
                          '*' => '\\*',
              Severity: Minor
              Found in framework/web/UrlRule.php by phpmd

              Since: PHPMD 0.1

              The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

              Example:

              class Foo {
                    function bar() {
                        // lots of complicated code
                    }
                }

              Source: http://phpmd.org/rules/codesize.txt

              The method parseRequest() has an NPath complexity of 46080. The configured NPath complexity threshold is 200.
              Open

                  public function parseRequest($manager, $request)
                  {
                      if ($this->mode === self::CREATION_ONLY) {
                          return false;
                      }
              Severity: Minor
              Found in framework/web/UrlRule.php by phpmd

              Since: PHPMD 0.1

              The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

              Example:

              class Foo {
                    function bar() {
                        // lots of complicated code
                    }
                }

              Source: http://phpmd.org/rules/codesize.txt

              The method preparePattern() has a Cyclomatic Complexity of 10. The configured cyclomatic complexity threshold is 10.
              Open

                  private function preparePattern()
                  {
                      $this->pattern = $this->trimSlashes($this->pattern);
                      $this->route = trim($this->route, '/');
              
              
              Severity: Minor
              Found in framework/web/UrlRule.php by phpmd

              Since: PHPMD 0.1

              Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

              Example:

              // Cyclomatic Complexity = 11
                class Foo {
                1   public function example() {
                2       if ($a == $b) {
                3           if ($a1 == $b1) {
                                fiddle();
                4           } elseif ($a2 == $b2) {
                                fiddle();
                            } else {
                                fiddle();
                            }
                5       } elseif ($c == $d) {
                6           while ($c == $d) {
                                fiddle();
                            }
                7        } elseif ($e == $f) {
                8           for ($n = 0; $n < $h; $n++) {
                                fiddle();
                            }
                        } else {
                            switch ($z) {
                9               case 1:
                                    fiddle();
                                    break;
                10              case 2:
                                    fiddle();
                                    break;
                11              case 3:
                                    fiddle();
                                    break;
                                default:
                                    fiddle();
                                    break;
                            }
                        }
                    }
                }

              Source: http://phpmd.org/rules/codesize.txt

              The method init() has a Cyclomatic Complexity of 11. The configured cyclomatic complexity threshold is 10.
              Open

                  public function init()
                  {
                      if ($this->pattern === null) {
                          throw new InvalidConfigException('UrlRule::pattern must be set.');
                      }
              Severity: Minor
              Found in framework/web/UrlRule.php by phpmd

              Since: PHPMD 0.1

              Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

              Example:

              // Cyclomatic Complexity = 11
                class Foo {
                1   public function example() {
                2       if ($a == $b) {
                3           if ($a1 == $b1) {
                                fiddle();
                4           } elseif ($a2 == $b2) {
                                fiddle();
                            } else {
                                fiddle();
                            }
                5       } elseif ($c == $d) {
                6           while ($c == $d) {
                                fiddle();
                            }
                7        } elseif ($e == $f) {
                8           for ($n = 0; $n < $h; $n++) {
                                fiddle();
                            }
                        } else {
                            switch ($z) {
                9               case 1:
                                    fiddle();
                                    break;
                10              case 2:
                                    fiddle();
                                    break;
                11              case 3:
                                    fiddle();
                                    break;
                                default:
                                    fiddle();
                                    break;
                            }
                        }
                    }
                }

              Source: http://phpmd.org/rules/codesize.txt

              The method translatePattern() has a Cyclomatic Complexity of 22. The configured cyclomatic complexity threshold is 10.
              Open

                  private function translatePattern($allowAppendSlash)
                  {
                      $tr = [
                          '.' => '\\.',
                          '*' => '\\*',
              Severity: Minor
              Found in framework/web/UrlRule.php by phpmd

              Since: PHPMD 0.1

              Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

              Example:

              // Cyclomatic Complexity = 11
                class Foo {
                1   public function example() {
                2       if ($a == $b) {
                3           if ($a1 == $b1) {
                                fiddle();
                4           } elseif ($a2 == $b2) {
                                fiddle();
                            } else {
                                fiddle();
                            }
                5       } elseif ($c == $d) {
                6           while ($c == $d) {
                                fiddle();
                            }
                7        } elseif ($e == $f) {
                8           for ($n = 0; $n < $h; $n++) {
                                fiddle();
                            }
                        } else {
                            switch ($z) {
                9               case 1:
                                    fiddle();
                                    break;
                10              case 2:
                                    fiddle();
                                    break;
                11              case 3:
                                    fiddle();
                                    break;
                                default:
                                    fiddle();
                                    break;
                            }
                        }
                    }
                }

              Source: http://phpmd.org/rules/codesize.txt

              The method createUrl() has a Cyclomatic Complexity of 31. The configured cyclomatic complexity threshold is 10.
              Open

                  public function createUrl($manager, $route, $params)
                  {
                      if ($this->mode === self::PARSING_ONLY) {
                          $this->createStatus = self::CREATE_STATUS_PARSING_ONLY;
                          return false;
              Severity: Minor
              Found in framework/web/UrlRule.php by phpmd

              Since: PHPMD 0.1

              Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

              Example:

              // Cyclomatic Complexity = 11
                class Foo {
                1   public function example() {
                2       if ($a == $b) {
                3           if ($a1 == $b1) {
                                fiddle();
                4           } elseif ($a2 == $b2) {
                                fiddle();
                            } else {
                                fiddle();
                            }
                5       } elseif ($c == $d) {
                6           while ($c == $d) {
                                fiddle();
                            }
                7        } elseif ($e == $f) {
                8           for ($n = 0; $n < $h; $n++) {
                                fiddle();
                            }
                        } else {
                            switch ($z) {
                9               case 1:
                                    fiddle();
                                    break;
                10              case 2:
                                    fiddle();
                                    break;
                11              case 3:
                                    fiddle();
                                    break;
                                default:
                                    fiddle();
                                    break;
                            }
                        }
                    }
                }

              Source: http://phpmd.org/rules/codesize.txt

              The method parseRequest() has a Cyclomatic Complexity of 21. The configured cyclomatic complexity threshold is 10.
              Open

                  public function parseRequest($manager, $request)
                  {
                      if ($this->mode === self::CREATION_ONLY) {
                          return false;
                      }
              Severity: Minor
              Found in framework/web/UrlRule.php by phpmd

              Since: PHPMD 0.1

              Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

              Example:

              // Cyclomatic Complexity = 11
                class Foo {
                1   public function example() {
                2       if ($a == $b) {
                3           if ($a1 == $b1) {
                                fiddle();
                4           } elseif ($a2 == $b2) {
                                fiddle();
                            } else {
                                fiddle();
                            }
                5       } elseif ($c == $d) {
                6           while ($c == $d) {
                                fiddle();
                            }
                7        } elseif ($e == $f) {
                8           for ($n = 0; $n < $h; $n++) {
                                fiddle();
                            }
                        } else {
                            switch ($z) {
                9               case 1:
                                    fiddle();
                                    break;
                10              case 2:
                                    fiddle();
                                    break;
                11              case 3:
                                    fiddle();
                                    break;
                                default:
                                    fiddle();
                                    break;
                            }
                        }
                    }
                }

              Source: http://phpmd.org/rules/codesize.txt

              There are no issues that match your filters.

              Category
              Status