yiisoft/yii2

View on GitHub
framework/widgets/LinkPager.php

Summary

Maintainability
A
1 hr
Test Coverage

The class LinkPager has 20 fields. Consider redesigning LinkPager to keep the number of fields under 15.
Open

class LinkPager extends Widget
{
    /**
     * @var Pagination the pagination object that this pager is associated with.
     * You must set this property in order to make LinkPager work.
Severity: Minor
Found in framework/widgets/LinkPager.php by phpmd

TooManyFields

Since: 0.1

Classes that have too many fields could be redesigned to have fewer fields, possibly through some nested object grouping of some of the information. For example, a class with city/state/zip fields could instead have one Address field.

Example

class Person {
   protected $one;
   private $two;
   private $three;
   [... many more fields ...]
}

Source https://phpmd.org/rules/codesize.html#toomanyfields

Function renderPageButtons has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

    protected function renderPageButtons()
    {
        $pageCount = $this->pagination->getPageCount();
        if ($pageCount < 2 && $this->hideOnSinglePage) {
            return '';
Severity: Minor
Found in framework/widgets/LinkPager.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method renderPageButton has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    protected function renderPageButton($label, $page, $class, $disabled, $active)
Severity: Minor
Found in framework/widgets/LinkPager.php - About 35 mins to fix

    The method renderPageButtons() has an NPath complexity of 864. The configured NPath complexity threshold is 200.
    Open

        protected function renderPageButtons()
        {
            $pageCount = $this->pagination->getPageCount();
            if ($pageCount < 2 && $this->hideOnSinglePage) {
                return '';
    Severity: Minor
    Found in framework/widgets/LinkPager.php by phpmd

    NPathComplexity

    Since: 0.1

    The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

    Example

    class Foo {
        function bar() {
            // lots of complicated code
        }
    }

    Source https://phpmd.org/rules/codesize.html#npathcomplexity

    The method renderPageButtons() has a Cyclomatic Complexity of 13. The configured cyclomatic complexity threshold is 10.
    Open

        protected function renderPageButtons()
        {
            $pageCount = $this->pagination->getPageCount();
            if ($pageCount < 2 && $this->hideOnSinglePage) {
                return '';
    Severity: Minor
    Found in framework/widgets/LinkPager.php by phpmd

    CyclomaticComplexity

    Since: 0.1

    Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

    Example

    // Cyclomatic Complexity = 11
    class Foo {
    1   public function example() {
    2       if ($a == $b) {
    3           if ($a1 == $b1) {
                    fiddle();
    4           } elseif ($a2 == $b2) {
                    fiddle();
                } else {
                    fiddle();
                }
    5       } elseif ($c == $d) {
    6           while ($c == $d) {
                    fiddle();
                }
    7        } elseif ($e == $f) {
    8           for ($n = 0; $n < $h; $n++) {
                    fiddle();
                }
            } else {
                switch ($z) {
    9               case 1:
                        fiddle();
                        break;
    10              case 2:
                        fiddle();
                        break;
    11              case 3:
                        fiddle();
                        break;
                    default:
                        fiddle();
                        break;
                }
            }
        }
    }

    Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

    Avoid assigning values to variables in if clauses and the like (line '210', column '18').
    Open

        protected function renderPageButtons()
        {
            $pageCount = $this->pagination->getPageCount();
            if ($pageCount < 2 && $this->hideOnSinglePage) {
                return '';
    Severity: Minor
    Found in framework/widgets/LinkPager.php by phpmd

    IfStatementAssignment

    Since: 2.7.0

    Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

    Example

    class Foo
    {
        public function bar($flag)
        {
            if ($foo = 'bar') { // possible typo
                // ...
            }
            if ($baz = 0) { // always false
                // ...
            }
        }
    }

    Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

    Avoid assigning values to variables in if clauses and the like (line '196', column '18').
    Open

        protected function renderPageButtons()
        {
            $pageCount = $this->pagination->getPageCount();
            if ($pageCount < 2 && $this->hideOnSinglePage) {
                return '';
    Severity: Minor
    Found in framework/widgets/LinkPager.php by phpmd

    IfStatementAssignment

    Since: 2.7.0

    Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

    Example

    class Foo
    {
        public function bar($flag)
        {
            if ($foo = 'bar') { // possible typo
                // ...
            }
            if ($baz = 0) { // always false
                // ...
            }
        }
    }

    Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

    Avoid assigning values to variables in if clauses and the like (line '268', column '14').
    Open

        protected function getPageRange()
        {
            $currentPage = $this->pagination->getPage();
            $pageCount = $this->pagination->getPageCount();
    
    
    Severity: Minor
    Found in framework/widgets/LinkPager.php by phpmd

    IfStatementAssignment

    Since: 2.7.0

    Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

    Example

    class Foo
    {
        public function bar($flag)
        {
            if ($foo = 'bar') { // possible typo
                // ...
            }
            if ($baz = 0) { // always false
                // ...
            }
        }
    }

    Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

    Avoid excessively long variable names like $disabledListItemSubTagOptions. Keep variable name length under 25.
    Open

        public $disabledListItemSubTagOptions = [];
    Severity: Minor
    Found in framework/widgets/LinkPager.php by phpmd

    LongVariable

    Since: 0.2

    Detects when a field, formal or local variable is declared with a long name.

    Example

    class Something {
        protected $reallyLongIntName = -3; // VIOLATION - Field
        public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
            $otherReallyLongName = -5; // VIOLATION - Local
            for ($interestingIntIndex = 0; // VIOLATION - For
                 $interestingIntIndex < 10;
                 $interestingIntIndex++ ) {
            }
        }
    }

    Source https://phpmd.org/rules/naming.html#longvariable

    There are no issues that match your filters.

    Category
    Status