Sign upLogin

yurijmi/better_offsite_payments

View on GitHub
Star
lib/offsite_payments/integrations/authorize_net_sim.rb

Summary

Maintainability
C
1 day
Test Coverage

Class Notification has 38 methods (exceeds 20 allowed). Consider refactoring.
Open

      class Notification < OffsitePayments::Notification

        def unescape(val) #:nodoc:
          if val
            CGI::unescape val
Severity: Minor
Found in lib/offsite_payments/integrations/authorize_net_sim.rb - About 5 hrs to fix

    File authorize_net_sim.rb has 271 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    module OffsitePayments #:nodoc:
  module Integrations #:nodoc:
    module AuthorizeNetSim
      # Overwrite this if you want to change the ANS test url
      mattr_accessor :test_url
    Severity: Minor
    Found in lib/offsite_payments/integrations/authorize_net_sim.rb - About 2 hrs to fix

      Method add_line_item has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

              def add_line_item(options)
          raise 'needs name' unless options[:name]

          if @line_item_count == 30
            # Add a note that we are not showing at least one -- AN doesn't
      Severity: Minor
      Found in lib/offsite_payments/integrations/authorize_net_sim.rb - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status