Sign upLogin

yurijmi/better_offsite_payments

View on GitHub
Star
lib/offsite_payments/integrations/paypal.rb

Summary

Maintainability
A
2 hrs
Test Coverage

Method shipping_address has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

        def shipping_address(params = {})
          # Get the country code in the correct format
          # Use what we were given if we can't find anything
          country_code = lookup_country_code(params.delete(:country))
          add_field(mappings[:shipping_address][:country], country_code)
Severity: Minor
Found in lib/offsite_payments/integrations/paypal.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method shipping_address has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        def shipping_address(params = {})
          # Get the country code in the correct format
          # Use what we were given if we can't find anything
          country_code = lookup_country_code(params.delete(:country))
          add_field(mappings[:shipping_address][:country], country_code)
Severity: Minor
Found in lib/offsite_payments/integrations/paypal.rb - About 1 hr to fix

    There are no issues that match your filters.

    Category
    Status