Sign upLogin

yurijmi/better_offsite_payments

View on GitHub
Star
lib/offsite_payments/integrations/pxpay.rb

Summary

Maintainability
A
3 hrs
Test Coverage

Class Notification has 27 methods (exceeds 20 allowed). Consider refactoring.
Open

      class Notification < OffsitePayments::Notification
        include ActiveUtils::PostsData
        include ActiveUtils::RequiresParameters

        def initialize(query_string, options={})
Severity: Minor
Found in lib/offsite_payments/integrations/pxpay.rb - About 3 hrs to fix

    Method credential_based_url has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

            def credential_based_url
          raw_response = ssl_post(Pxpay.token_url, generate_request)
          result = parse_response(raw_response)

          raise ActionViewHelperError, "error - failed to get token - message was #{result[:redirect]}" unless result[:valid] == "1"
    Severity: Minor
    Found in lib/offsite_payments/integrations/pxpay.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status