Sign upLogin

zendesk/zendesk_api_client_rb

View on GitHub
Star
lib/zendesk_api/middleware/request/upload.rb

Summary

Maintainability
B
5 hrs
Test Coverage

Method set_file has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
Open

        def set_file(hash, key, top_level)
          return unless hash.key?(key)

          file = if hash[key].is_a?(Hash) && hash[key].key?(:file)
            hash[key].delete(:file)
Severity: Minor
Found in lib/zendesk_api/middleware/request/upload.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method set_file has 35 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        def set_file(hash, key, top_level)
          return unless hash.key?(key)

          file = if hash[key].is_a?(Hash) && hash[key].key?(:file)
            hash[key].delete(:file)
Severity: Minor
Found in lib/zendesk_api/middleware/request/upload.rb - About 1 hr to fix

    Method traverse_hash has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

            def traverse_hash(hash)
          hash.keys.each do |key|
            if hash[key].is_a?(File)
              set_file(hash, key, false)
            elsif hash[key].is_a?(Hash)
    Severity: Minor
    Found in lib/zendesk_api/middleware/request/upload.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status