Sign upLogin

zenkay/simple-spreadsheet

View on GitHub
Star

Showing 4 of 7 total issues

Method foreach has a Cognitive Complexity of 61 (exceeds 5 allowed). Consider refactoring.
Open

    def foreach(sheet = nil, &block)
      sheet = @default_sheet unless sheet
      sheet_found = false
      raise ArgumentError, "Error: sheet '#{sheet||'nil'}' not valid" if @default_sheet == nil and sheet==nil
      raise RangeError unless self.sheets.include? sheet
Severity: Minor
Found in lib/simple-spreadsheet/classes/excelx_extended.rb - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method foreach has 97 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def foreach(sheet = nil, &block)
      sheet = @default_sheet unless sheet
      sheet_found = false
      raise ArgumentError, "Error: sheet '#{sheet||'nil'}' not valid" if @default_sheet == nil and sheet==nil
      raise RangeError unless self.sheets.include? sheet
Severity: Major
Found in lib/simple-spreadsheet/classes/excelx_extended.rb - About 3 hrs to fix

    Method foreach has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
    Open

      def foreach(sheet=nil, &block)
    sheet = @default_sheet unless sheet
    raise ArgumentError, "Error: sheet '#{sheet||'nil'}' not valid" if @default_sheet == nil and sheet==nil
    raise RangeError unless self.sheets.include? sheet
    Severity: Minor
    Found in lib/simple-spreadsheet/classes/excel_extended.rb - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method foreach has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def foreach(sheet=nil, &block)
    sheet = @default_sheet unless sheet
    raise ArgumentError, "Error: sheet '#{sheet||'nil'}' not valid" if @default_sheet == nil and sheet==nil
    raise RangeError unless self.sheets.include? sheet
    Severity: Minor
    Found in lib/simple-spreadsheet/classes/excel_extended.rb - About 1 hr to fix
      Severity
      Category
      Status
      Source
      Language