zold-io/zold

View on GitHub
lib/zold/node/async_entrance.rb

Summary

Maintainability
A
2 hrs
Test Coverage

Method start has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def start
      raise 'Block must be given to start()' unless block_given?
      FileUtils.mkdir_p(@dir)
      DirItems.new(@dir).fetch.each do |f|
        file = File.join(@dir, f)
Severity: Minor
Found in lib/zold/node/async_entrance.rb - About 1 hr to fix

    Method push has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        def push(id, body)
          if @queue.size > @queue_limit
            raise(
              SoftError,
              "Queue is too long (#{@queue.size} wallets), can't add #{id}/#{Size.new(body.length)}, try again later"
    Severity: Minor
    Found in lib/zold/node/async_entrance.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method start has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        def start
          raise 'Block must be given to start()' unless block_given?
          FileUtils.mkdir_p(@dir)
          DirItems.new(@dir).fetch.each do |f|
            file = File.join(@dir, f)
    Severity: Minor
    Found in lib/zold/node/async_entrance.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method exists? has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        def exists?(id, body)
          DirItems.new(@dir).fetch.each do |f|
            next unless f.start_with?("#{id}-")
            return true if safe_read(File.join(@dir, f)) == body
          end
    Severity: Minor
    Found in lib/zold/node/async_entrance.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status