Sign upLogin

zold-io/zold

View on GitHub
Star
lib/zold/node/farm.rb

Summary

Maintainability
B
5 hrs
Test Coverage

Method cycle has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

    def cycle(host, port, threads)
      s = []
      loop do
        begin
          s << @pipeline.pop(true)
Severity: Minor
Found in lib/zold/node/farm.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method start has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

    def start(host, port, threads: Concurrent.processor_count)
      raise 'Block is required for the farm to start' unless block_given?
      @log.info('Zero-threads farm won\'t score anything!') if threads.zero?
      if best.empty?
        @log.info("No scores found in the cache at #{@cache}")
Severity: Minor
Found in lib/zold/node/farm.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method start has 38 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def start(host, port, threads: Concurrent.processor_count)
      raise 'Block is required for the farm to start' unless block_given?
      @log.info('Zero-threads farm won\'t score anything!') if threads.zero?
      if best.empty?
        @log.info("No scores found in the cache at #{@cache}")
Severity: Minor
Found in lib/zold/node/farm.rb - About 1 hr to fix

    There are no issues that match your filters.

    Category
    Status