zuazo/postfixadmin-cookbook

View on GitHub

Showing 5 of 14 total issues

File metadata.rb has 298 lines of code (exceeds 250 allowed). Consider refactoring.
Open

name 'postfixadmin'
maintainer 'Xabier de Zuazo'
maintainer_email 'xabier@zuazo.org'
license 'Apache 2.0'
description 'Installs and configures PostfixAdmin, a web based interface used '\
Severity: Minor
Found in metadata.rb - About 3 hrs to fix

    Method request has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

          def request(method, path, body, ssl, port)
    Severity: Minor
    Found in libraries/api_http.rb - About 35 mins to fix

      Method initialize has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

              def initialize(method, path, body, ssl, port)
      Severity: Minor
      Found in libraries/api_http.rb - About 35 mins to fix

        Method parse_response has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

              def parse_response(body, regexps = nil)
                (regexps ? [regexps].flatten : ERROR_REGEXS).each do |regexp|
                  next unless body.match(regexp)
                  error(strip_html(body.gsub(regexp, '\1')))
                end
        Severity: Minor
        Found in libraries/api_http.rb - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method create_to_table has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            def create_to_table(table, value)
              %i(active superadmin welcome_mail default_aliases).each do |key|
                value[key] = value[key] ? 1 : 0 if value.key?(key)
              end
              value[:password2] = value[:password] if value.key?(:password)
        Severity: Minor
        Found in libraries/api.rb - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Severity
        Category
        Status
        Source
        Language