Showing 23 of 591 total issues
Method notify_observers has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
def notify_observers(needs_review, comment)
only_observers.each do |observer|
unless user_is_modifier?(observer, comment.user)
if observer.role_on(proposal).observer_only?
if needs_review == true- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method get_content_tag has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def get_content_tag(element, adjusted_time, adjusted_time_str, ago, opts)
if ago
if !adjusted_time.today? && opts[:truncate]
content_tag(element, adjusted_time_str, title: adjusted_time_str)
else- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method datespan_header has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def datespan_header(start_date, end_date)
if start_date && end_date
# month span
if start_date.mday == 1 && end_date == start_date + 1.month
month_name = I18n.t('date.abbr_month_names')[start_date.month]- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"