Sign upLogin

18F/e-QIP-prototype

View on GitHub
Star
src/validators/location.js

Summary

Maintainability
B
5 hrs
Test Coverage

Function validFields has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

  validFields(fields) {
    if (!fields || !fields.length) {
      return false
    }
Severity: Minor
Found in src/validators/location.js - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function validLocation has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

  validLocation() {
    switch (this.layout) {
      case Layouts.BIRTHPLACE:
        if (this.isDomestic()) {
          return this.validFields(['city', 'state', 'county'])
Severity: Minor
Found in src/validators/location.js - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function countryString has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

export const countryString = (country) => {
  if (validate.isHash(country)) {
    if (country.value === null) return null
    if (country.value === undefined) return undefined
Severity: Minor
Found in src/validators/location.js - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this function.
Open

        return this.validFields(['city', 'country'])
Severity: Major
Found in src/validators/location.js - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

              return this.validFields(['city', 'stateZipcode', 'county'])
    Severity: Major
    Found in src/validators/location.js - About 30 mins to fix

      Resolve error: unable to load resolver "babel-module".
      Open

      import { validate } from 'validate.js'
      Severity: Minor
      Found in src/validators/location.js by eslint

      For more information visit Source: http://eslint.org/docs/rules/

      There are no issues that match your filters.

      Category
      Status