Sign upLogin

18F/federalist

View on GitHub
Star
api/models/build.js

Summary

Maintainability
C
1 day
Test Coverage
A
98%

Function exports has 86 lines of code (exceeds 25 allowed). Consider refactoring.
Open

module.exports = (sequelize, DataTypes) => {
  const Build = sequelize.define(
    'Build',
    {
      branch: {
Severity: Major
Found in api/models/build.js - About 3 hrs to fix

    File build.js has 279 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    const { Op } = require('sequelize');
const crypto = require('crypto');
const URLSafeBase64 = require('urlsafe-base64');
const SiteBuildQueue = require('../services/SiteBuildQueue');
    Severity: Minor
    Found in api/models/build.js - About 2 hrs to fix

      Function enqueue has 29 lines of code (exceeds 25 allowed). Consider refactoring.
      Wontfix

      async function enqueue() {
  const build = this;

  const {
    Site, User, Build, UserEnvironmentVariable, SiteBranchConfig,
      Severity: Minor
      Found in api/models/build.js - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          Build.addScope('byOrg', id => ({
    include: [
      {
        model: Site,
        required: true,
        Severity: Major
        Found in api/models/build.js and 1 other location - About 1 hr to fix
        api/models/domain.js on lines 52..62

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 63.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

              state: {
        type: DataTypes.ENUM,
        values: States.values,
        defaultValue: States.Created,
        allowNull: false,
        Severity: Major
        Found in api/models/build.js and 1 other location - About 1 hr to fix
        api/models/domain.js on lines 111..119

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 55.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status