18F/federalist

CloudFoundryAPIClient has 27 functions (exceeds 20 allowed). Consider refactoring.

Open

class CloudFoundryAPIClient {
  constructor({ apiUrl, authClient } = {}) {
    this.authClient = authClient ?? new CloudFoundryAuthClient();
    this.httpClient = new HttpClient(apiUrl ?? process.env.CLOUD_FOUNDRY_API_HOST);
  }

File cfApiClient.js has 266 lines of code (exceeds 250 allowed). Consider refactoring.

Open

const CloudFoundryAuthClient = require('./cfAuthClient');
const HttpClient = require('./httpClient');

function filterEntity(res, name, field = 'name') {
  const errMsg = `Not found: Entity @${field} = ${name}`;

Function createExternalDomain has 32 lines of code (exceeds 25 allowed). Consider refactoring.

Open

  async createExternalDomain(params) {
    const {
      domains,
      name,
      origin,

Identical blocks of code found in 2 locations. Consider refactoring.

Open

  async createExternalDomain(params) {
    const {
      domains,
      name,
      origin,

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

  deleteRoute(host) {
    return this.accessToken()
      .then(token => this.request(
        'GET',
        `/v2/routes?q=host:${host}`,

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

  fetchServiceInstanceCredentials(name) {
    return this.fetchServiceInstance(name)
      .then(instance => this.accessToken().then(token => this.request(
        'GET',
        `/v2/service_instances/${instance.metadata.guid}/service_keys`,

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

function filterEntity(res, name, field = 'name') {
  const errMsg = `Not found: Entity @${field} = ${name}`;
  const filtered = res.resources.filter(item => item.entity[field] === name);
  if (filtered.length === 0) {
    const error = new Error(errMsg);

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

  deleteServiceInstance(name) {
    return this.fetchServiceInstance(name)
      .then(instance => this.accessToken().then(token => this.request(
        'DELETE',
        `/v2/service_instances/${instance.metadata.guid}?accepts_incomplete=true&recursive=true&async=true`,

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

  createS3ServiceInstance(name, serviceName, spaceGuid, s3ServicePlanId) {
    return this.fetchS3ServicePlanGUID(serviceName, s3ServicePlanId)
      .then((servicePlanGuid) => {
        const body = {
          name,

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

  fetchServiceKey(name) {
    return this.fetchServiceKeys()
      .then(res => findEntity(res, name))
      .then(key => this.accessToken().then(token => this.request(
        'GET',

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

  if (name === 'basic-public') {
    const servicePlan = filtered.find(f => f.entity.unique_id === s3ServicePlanId);
    if (!servicePlan) {
      const error = new Error(`Not found: @basic-public service plan = (${s3ServicePlanId})`);
      error.name = name;

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

  createServiceKey(serviceInstanceName, serviceInstanceGuid, keyIdentifier = 'key') {
    const body = {
      name: `${serviceInstanceName}-${keyIdentifier}`,
      service_instance_guid: serviceInstanceGuid,
    };

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

  request(method, path, accessToken, json) {
    return this.httpClient.request({
      method,
      url: path,
      headers: {

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

  fetchS3ServicePlanGUID(serviceName, s3ServicePlanId) {
    return this.accessToken().then(token => this.request(
      'GET',
      '/v2/service_plans',
      token

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

  constructor({ apiUrl, authClient } = {}) {
    this.authClient = authClient ?? new CloudFoundryAuthClient();
    this.httpClient = new HttpClient(apiUrl ?? process.env.CLOUD_FOUNDRY_API_HOST);
  }

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

  createRoute(name, domainGuid, spaceGuid) {
    const body = {
      domain_guid: domainGuid,
      space_guid: spaceGuid,
      host: name,

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

  async cancelBuildTask(buildId) {
    const buildTask = await this.fetchBuildTask(buildId);
    if (!buildTask) {
      throw new Error(`There are no tasks for build id: ${buildId}`);
    }

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

  fetchTasks(params) {
    const qs = objToQueryParams(params);

    return this.authRequest('GET', `/v3/tasks?${qs.toString()}`)
      .then(body => body.resources);

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

  createSiteBucket(name, spaceGuid, s3ServicePlanId, keyIdentifier = 'key', serviceName = 'basic-public') {
    return this.createS3ServiceInstance(name, serviceName, spaceGuid, s3ServicePlanId)
      .then(res => this.createServiceKey(name, res.metadata.guid, keyIdentifier));
  }

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

function firstEntity(res, name) {
  if (res.resources.length === 0) {
    const error = new Error('Not found');
    error.name = name;
    throw error;

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

function objToQueryParams(obj) {
  const qs = new URLSearchParams();
  Object
    .entries(obj)
    .forEach(([key, value]) => {

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

  fetchTaskByName(name) {
    return this.fetchTasks({ names: name })
      .then(tasks => tasks.find(task => task.name === name));
  }

• Read up
  Read up