Sign upLogin

18F/federalist

View on GitHub
Star

Showing 83 of 394 total issues

Function verify has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

  const verify = async (req, accessToken, refreshToken, profile, callback) => {
    try {
      const supportUser = await verifyUAAUser(accessToken, refreshToken, profile, ['pages.support']);
      if (supportUser) {
        req.session.role = 'pages.support';
Severity: Minor
Found in api/admin/passport.js - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function parseGithubErrorMessage has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

const parseGithubErrorMessage = (error) => {
  let githubError = 'Encountered an unexpected GitHub error';

  try {
    githubError = error.response.data.errors[0].message;
Severity: Minor
Found in api/services/GitHub.js - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function fetchWrapper has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

function fetchWrapper(url, configs = {}) {
  const baseConfigs = {
    credentials: configs.credentials || credentials,
    headers: { ...defaultHeaders, ...configs.headers || {} },
    method: configs.method || defaultMethod,
Severity: Minor
Found in frontend/util/fetch.js - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language