Sign upLogin

18F/samwise

View on GitHub
Star

Showing 5 of 5 total issues

Method wrap_sam has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    def wrap_sam(jsonOutKey, &block)
      infile = ($stdin.tty?) ? File.read(options[:infile]) : $stdin.read       #read in a json of users to be samwised
      duns_hash = JSON.parse(infile)
      #check what method called wrap_sam. Do not init samwise client for utils
      thor_method = caller_locations(1,1)[0].label
Severity: Minor
Found in lib/samwise/cli.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this method.
Open

      return true if duns_is_thirteen_digits?(duns: duns)
Severity: Major
Found in lib/samwise/util.rb - About 30 mins to fix

    Avoid too many return statements within this method.
    Open

          return false
    Severity: Major
    Found in lib/samwise/util.rb - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

            return true if duns_is_nine_digits?(duns: duns)
      Severity: Major
      Found in lib/samwise/util.rb - About 30 mins to fix

        Method duns_is_properly_formatted? has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            def self.duns_is_properly_formatted?(duns: nil)
      return false if duns.nil?

      duns = duns.gsub('-', '')
        Severity: Minor
        Found in lib/samwise/util.rb - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Severity
        Category
        Status
        Source
        Language