Sign upLogin

18F/trello-webhook-server

View on GitHub
Star

Showing 6 of 17 total issues

Function constructor has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
Open

  constructor(config) { // port, host, apiKey, apiToken, clientSecret) {
    if (!config) {
      throw new Error('Config is required');
    }
    this.config = { };
Severity: Minor
Found in src/webhook-server.js - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function constructor has 40 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  constructor(config) { // port, host, apiKey, apiToken, clientSecret) {
    if (!config) {
      throw new Error('Config is required');
    }
    this.config = { };
Severity: Minor
Found in src/webhook-server.js - About 1 hr to fix

    Function getHandler has 39 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    module.exports = function getHandler(tws, handlers) {
  if (typeof handlers !== 'object') {
    handlers = { }; // eslint-disable-line no-param-reassign
  }
    Severity: Minor
    Found in src/http-handler.js - About 1 hr to fix

      Function httpHandler has 34 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        return function httpHandler(req, response) {
    const res = response;
    if (req.method.toLowerCase() === 'head') {
      res.statusCode = 200;
      res.end();
      Severity: Minor
      Found in src/http-handler.js - About 1 hr to fix

        Function register has 29 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          register(callbackURL, modelID) {
    return new Promise((resolve, reject) => {
      if (!this.webhookID) {
        request.post('https://api.trello.com/1/webhooks', {
          body: {
        Severity: Minor
        Found in src/register-webhook.js - About 1 hr to fix

          Function getHandler has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
          Open

          module.exports = function getHandler(tws, handlers) {
  if (typeof handlers !== 'object') {
    handlers = { }; // eslint-disable-line no-param-reassign
  }
          Severity: Minor
          Found in src/http-handler.js - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Severity
          Category
          Status
          Source
          Language