200ok-ch/organice

View on GitHub
src/components/OrgFile/index.js

Summary

Maintainability
D
1 day
Test Coverage

OrgFile has 44 functions (exceeds 20 allowed). Consider refactoring.
Open

class OrgFile extends PureComponent {
  constructor(props) {
    super(props);

    _.bindAll(this, [
Severity: Minor
Found in src/components/OrgFile/index.js - About 6 hrs to fix

    Function render has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
    Open

      render() {
        const {
          headers,
          linesBeforeHeadings,
          shouldDisableDirtyIndicator,
    Severity: Minor
    Found in src/components/OrgFile/index.js - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function renderActivePopup has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
    Open

      renderActivePopup(setPopupCloseActionValuesAccessor) {
        const {
          activePopupType,
          activePopupData,
          captureTemplates,
    Severity: Minor
    Found in src/components/OrgFile/index.js - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function componentDidMount has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

      componentDidMount() {
        const { staticFile, path } = this.props;
    
        if (!!staticFile) {
          this.props.org.setPath(STATIC_FILE_PREFIX + staticFile);
    Severity: Minor
    Found in src/components/OrgFile/index.js - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this function.
    Open

        return (
          <GlobalHotKeys keyMap={keyMap} handlers={handlers}>
            <div className="org-file-container" tabIndex="-1" ref={this.handleContainerRef}>
              {headers.size === 0 ? (
                <div className="org-file__parsing-error-message">
    Severity: Major
    Found in src/components/OrgFile/index.js - About 30 mins to fix

      Function saveTitle has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

        saveTitle(titleValue) {
          const { selectedHeader } = this.props;
          if (this.state.editRawValues) {
            if (generateTitleLine(selectedHeader.toJS(), false) !== titleValue) {
              this.props.org.updateHeaderTitle(selectedHeader.get('id'), titleValue);
      Severity: Minor
      Found in src/components/OrgFile/index.js - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function handleDescriptionPopupClose has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

        handleDescriptionPopupClose(descriptionValue) {
          const { selectedHeader } = this.props;
          if (this.state.editRawValues) {
            if (
              createRawDescriptionText(selectedHeader, false, this.props.dontIndent) !== descriptionValue
      Severity: Minor
      Found in src/components/OrgFile/index.js - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          const {
            headers,
            linesBeforeHeadings,
            shouldDisableDirtyIndicator,
            shouldDisableSyncButtons,
      Severity: Major
      Found in src/components/OrgFile/index.js and 1 other location - About 1 hr to fix
      src/components/OrgFile/components/ActionDrawer/index.js on lines 20..33

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 62.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        handleSyncConfirmationPull(path) {
          this.props.org.sync({ path, forceAction: 'pull' });
          this.props.base.closePopup();
        }
      Severity: Major
      Found in src/components/OrgFile/index.js and 1 other location - About 1 hr to fix
      src/components/OrgFile/index.js on lines 323..326

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 57.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        handleSyncConfirmationPush(path) {
          this.props.org.sync({ path, forceAction: 'push' });
          this.props.base.closePopup();
        }
      Severity: Major
      Found in src/components/OrgFile/index.js and 1 other location - About 1 hr to fix
      src/components/OrgFile/index.js on lines 318..321

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 57.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Parsing error: Unexpected token 668 | <fragment> 669 | {noHeadlineButContent() ? (</fragment>
      Open

                          <>
      Severity: Minor
      Found in src/components/OrgFile/index.js by eslint

      For more information visit Source: http://eslint.org/docs/rules/

      There are no issues that match your filters.

      Category
      Status