Sign upLogin

4minitz/4minitz

View on GitHub
Star
client/templates/minutes/minutesedit.js

Summary

Maintainability
C
1 day
Test Coverage

File minutesedit.js has 542 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import moment from 'moment/moment';
import { Template } from 'meteor/templating';
import { i18n } from 'meteor/universe:i18n';
import { Blaze } from 'meteor/blaze';
import { Session } from 'meteor/session';
Severity: Major
Found in client/templates/minutes/minutesedit.js - About 1 day to fix

    `` has 22 functions (exceeds 20 allowed). Consider refactoring.
    Wontfix

    Template.minutesedit.helpers({
    setDocumentTitle() {
        let min = new Minutes(_minutesID);
        let ms = min.parentMeetingSeries();
        document.title = `4M! ${ms.name} [${ms.project}] ${min.date}`;
    Severity: Minor
    Found in client/templates/minutes/minutesedit.js - About 2 hrs to fix

      Function initialize has 37 lines of code (exceeds 25 allowed). Consider refactoring.
      Wontfix

          initialize() {
        let templateInstance = Template.instance();

        $(document).arrive('#id_minutesdatePicker', () => {
            // Configure DateTimePicker
      Severity: Minor
      Found in client/templates/minutes/minutesedit.js - About 1 hr to fix

        Function click #btn_sendAgenda has 34 lines of code (exceeds 25 allowed). Consider refactoring.
        Wontfix

            'click #btn_sendAgenda': async function(evt, tmpl) {
        evt.preventDefault();
        let sendBtn = tmpl.$('#btn_sendAgenda');
        let aMin = new Minutes(_minutesID);
        console.log('Send agenda: ' + aMin._id + ' from series: ' + aMin.meetingSeries_id);
        Severity: Minor
        Found in client/templates/minutes/minutesedit.js - About 1 hr to fix

          Function updateTopicSorting has 34 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          let updateTopicSorting = function (event, ui) {
    const draggedTopicID = $(ui.item).attr('data-id');
    if (!draggedTopicID) {
        return;
    }
          Severity: Minor
          Found in client/templates/minutes/minutesedit.js - About 1 hr to fix

            Function click #btn_finalizeMinutes has 34 lines of code (exceeds 25 allowed). Consider refactoring.
            Wontfix

                'click #btn_finalizeMinutes': function(evt, tmpl) {
        evt.preventDefault();
        let aMin = new Minutes(_minutesID);
        console.log('Finalize minutes: ' + aMin._id + ' from series: ' + aMin.meetingSeries_id);
            Severity: Minor
            Found in client/templates/minutes/minutesedit.js - About 1 hr to fix

              Function handleTemplatesGlobalKeyboardShortcuts has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
              Open

              let handleTemplatesGlobalKeyboardShortcuts = function(switchOn) {
    if (switchOn) {
        $(document).keydown( function(evt) {
            if ($('.modal.in').length > 0) {    // any modal dialog open?
                return;
              Severity: Minor
              Found in client/templates/minutes/minutesedit.js - About 55 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function updateTopicSorting has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
              Open

              let updateTopicSorting = function (event, ui) {
    const draggedTopicID = $(ui.item).attr('data-id');
    if (!draggedTopicID) {
        return;
    }
              Severity: Minor
              Found in client/templates/minutes/minutesedit.js - About 55 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function click #btn_finalizeMinutes has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
              Wontfix

                  'click #btn_finalizeMinutes': function(evt, tmpl) {
        evt.preventDefault();
        let aMin = new Minutes(_minutesID);
        console.log('Finalize minutes: ' + aMin._id + ' from series: ' + aMin.meetingSeries_id);
              Severity: Minor
              Found in client/templates/minutes/minutesedit.js - About 55 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Wontfix

                      let noProtocolExistsDialog = (downloadHTML) => {
            ConfirmationDialogFactory.makeSuccessDialogWithTemplate(
                downloadHTML,
                i18n.__('Dialog.ConfirmGenerateProtocol.title'),
                'confirmPlainText',
              Severity: Major
              Found in client/templates/minutes/minutesedit.js and 1 other location - About 1 hr to fix
              client/templates/globals/profileEditDialog.js on lines 62..70

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 55.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 4 locations. Consider refactoring.
              Wontfix

                  authenticating() {
        const subscriptionReady = Template.instance().minutesReady.get();
        return Meteor.loggingIn() || !subscriptionReady;
    },
              Severity: Major
              Found in client/templates/minutes/minutesedit.js and 3 other locations - About 40 mins to fix
              client/templates/home.js on lines 36..39
              client/templates/meetingseries/meetingSeriesDetails.js on lines 72..75
              client/templates/topic/topicViewOne.js on lines 52..55

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 49.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status