4minitz/4minitz

View on GitHub
client/templates/topic/topicInfoItemList.js

Summary

Maintainability
F
3 days
Test Coverage

File topicInfoItemList.js has 537 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import { Topic } from '/imports/topic';
import { Meteor } from 'meteor/meteor';
import { Template } from 'meteor/templating';
import { Session } from 'meteor/session';
import { $ } from 'meteor/jquery';
Severity: Major
Found in client/templates/topic/topicInfoItemList.js - About 1 day to fix

    Function click .detailText has 52 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        'click .detailText'(evt, tmpl) {
            evt.preventDefault();
            /** @type {TopicInfoItemListContext} */
            const context = tmpl.data;
    
    
    Severity: Major
    Found in client/templates/topic/topicInfoItemList.js - About 2 hrs to fix

      Function click #btnDelInfoItem has 49 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          'click #btnDelInfoItem'(evt, tmpl) {
              /** @type {TopicInfoItemListContext} */
              const context = tmpl.data;
              performActionForItem(evt, tmpl, (item) => {
                  let isDeleteAllowed = item.isDeleteAllowed(context.getSeriesId(item._infoItemDoc._id));
      Severity: Minor
      Found in client/templates/topic/topicInfoItemList.js - About 1 hr to fix

        Function blur .detailInput has 47 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            'blur .detailInput'(evt, tmpl) {
                evt.preventDefault();
                /** @type {TopicInfoItemListContext} */
                const context = tmpl.data;
        
        
        Severity: Minor
        Found in client/templates/topic/topicInfoItemList.js - About 1 hr to fix

          Function blur .detailInput has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
          Open

              'blur .detailInput'(evt, tmpl) {
                  evt.preventDefault();
                  /** @type {TopicInfoItemListContext} */
                  const context = tmpl.data;
          
          
          Severity: Minor
          Found in client/templates/topic/topicInfoItemList.js - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function topicStateClass has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

              topicStateClass: function (index) {
                  /** @type {TopicInfoItemListContext} */
                  const context = Template.instance().data;
                  let infoItem = context.items[index];
                  if (infoItem && infoItem.itemType !== 'actionItem') {
          Severity: Minor
          Found in client/templates/topic/topicInfoItemList.js - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Avoid too many return statements within this function.
          Open

                      return 'actionitem-closed';
          Severity: Major
          Found in client/templates/topic/topicInfoItemList.js - About 30 mins to fix

            Function click .detailText has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                'click .detailText'(evt, tmpl) {
                    evt.preventDefault();
                    /** @type {TopicInfoItemListContext} */
                    const context = tmpl.data;
            
            
            Severity: Minor
            Found in client/templates/topic/topicInfoItemList.js - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                'hide.bs.collapse'(evt, tmpl) {
                    let itemID = $(evt.currentTarget).data('itemid');
                    let expandStates = tmpl.isItemExpanded.get();
                    expandStates[itemID] = false;
                    tmpl.isItemExpanded.set(expandStates);
            Severity: Major
            Found in client/templates/topic/topicInfoItemList.js and 1 other location - About 2 hrs to fix
            client/templates/topic/topicInfoItemList.js on lines 656..661

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 77.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                'show.bs.collapse'(evt, tmpl) {
                    let itemID = $(evt.currentTarget).data('itemid');
                    let expandStates = tmpl.isItemExpanded.get();
                    expandStates[itemID] = true;
                    tmpl.isItemExpanded.set(expandStates);
            Severity: Major
            Found in client/templates/topic/topicInfoItemList.js and 1 other location - About 2 hrs to fix
            client/templates/topic/topicInfoItemList.js on lines 650..655

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 77.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                'click .btnToggleAIState'(evt, tmpl) {
                    performActionForItem(evt, tmpl, (item) => {
                        if (item instanceof ActionItem) {
                            item.toggleState();
                            item.save().catch(handleError);
            Severity: Major
            Found in client/templates/topic/topicInfoItemList.js and 1 other location - About 1 hr to fix
            client/templates/topic/topicInfoItemList.js on lines 460..467

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 64.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                'click .btnPinInfoItem'(evt, tmpl) {
                    performActionForItem(evt, tmpl, (item) => {
                        if (item instanceof InfoItem) {
                            item.toggleSticky();
                            item.save().catch(handleError);
            Severity: Major
            Found in client/templates/topic/topicInfoItemList.js and 1 other location - About 1 hr to fix
            client/templates/topic/topicInfoItemList.js on lines 427..434

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 64.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    if (evt.which === 13/*enter*/ && ( evt.ctrlKey || evt.metaKey)) {
                        evt.preventDefault();
                        inputEl.blur();
                    }
            Severity: Major
            Found in client/templates/topic/topicInfoItemList.js and 1 other location - About 1 hr to fix
            client/templates/topic/topicElement.js on lines 333..336

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 55.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    const unset = function () {
                        IsEditedService.removeIsEditedDetail(aMin._id, aTopic._topicDoc._id, aActionItem._infoItemDoc._id, detailIndex, true);
                    };
            Severity: Minor
            Found in client/templates/topic/topicInfoItemList.js and 1 other location - About 35 mins to fix
            client/templates/topic/topicInfoItemList.js on lines 527..529

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 47.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                        let unset = function () {
                            IsEditedService.removeIsEditedDetail(aMin._id, aTopic._topicDoc._id, aActionItem._infoItemDoc._id, detailIndex, true);
                        };
            Severity: Minor
            Found in client/templates/topic/topicInfoItemList.js and 1 other location - About 35 mins to fix
            client/templates/topic/topicInfoItemList.js on lines 553..555

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 47.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                    else {
                        IsEditedService.setIsEditedDetail(aMin._id, aTopic._topicDoc._id, aActionItem._infoItemDoc._id, detailIndex);
                        makeDetailEditable(textEl, inputEl, detailActionsId);
                    }
            Severity: Minor
            Found in client/templates/topic/topicInfoItemList.js and 1 other location - About 35 mins to fix
            client/templates/topic/topicInfoItemList.js on lines 556..559

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 46.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                    const setIsEdited = () => {
                        IsEditedService.setIsEditedDetail(aMin._id, aTopic._topicDoc._id, aActionItem._infoItemDoc._id, detailIndex);
                        makeDetailEditable(textEl, inputEl, detailActionsId);
                    };
            Severity: Minor
            Found in client/templates/topic/topicInfoItemList.js and 1 other location - About 35 mins to fix
            client/templates/topic/topicInfoItemList.js on lines 547..550

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 46.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status