Sign upLogin

4minitz/4minitz

View on GitHub
Star
imports/collections/documentgeneration_private.js

Summary

Maintainability
C
1 day
Test Coverage

Function documentgeneration.createAndStoreFile has 58 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    'documentgeneration.createAndStoreFile'(minutesId) {
        if (Meteor.isClient) {
            return;
        }
        if (! Meteor.settings.public.docGeneration.enabled) {
Severity: Major
Found in imports/collections/documentgeneration_private.js - About 2 hrs to fix

    Function documentgeneration.createHTML has 32 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        'documentgeneration.createHTML'(minuteID) {
        if (Meteor.isClient) {
            return;
        }
    Severity: Minor
    Found in imports/collections/documentgeneration_private.js - About 1 hr to fix

      Function onBeforeUpload has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          onBeforeUpload: function (file) {
        if (! Meteor.settings.public.docGeneration.enabled) {
            return 'Document Generation not enabled in settings.json';
        }
        if (! Meteor.userId()) {
      Severity: Minor
      Found in imports/collections/documentgeneration_private.js - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function documentgeneration.createAndStoreFile has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          'documentgeneration.createAndStoreFile'(minutesId) {
        if (Meteor.isClient) {
            return;
        }
        if (! Meteor.settings.public.docGeneration.enabled) {
      Severity: Minor
      Found in imports/collections/documentgeneration_private.js - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this function.
      Open

              return true;
      Severity: Major
      Found in imports/collections/documentgeneration_private.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                    return 'Document Genration not possible. User is not Moderator of this meeting series.';
        Severity: Major
        Found in imports/collections/documentgeneration_private.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                      return 'Document Generation not possible. Minutes are not finalized.';
          Severity: Major
          Found in imports/collections/documentgeneration_private.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                        return 'Document Generation not possible. File has no minute date.';
            Severity: Major
            Found in imports/collections/documentgeneration_private.js - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                      return true;    // OK - Download allowed
              Severity: Major
              Found in imports/collections/documentgeneration_private.js - About 30 mins to fix

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    onAfterUpload: function (file) {
        console.log('Successfully created protocol: ' + file.name + ' to ' + file.path);
        DocumentsCollection.update(file._id, {$set: {'meta.timestamp': new Date()}});
    },
                Severity: Major
                Found in imports/collections/documentgeneration_private.js and 1 other location - About 1 hr to fix
                imports/collections/attachments_private.js on lines 81..84

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 73.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                        if (! ur.hasViewRoleFor(file.meta.meetingSeriesId)) {
            console.log('Protocol download prohibited. User has no view role for meeting series: ' + file.meta.meetingSeriesId);
            return false;
        }
                Severity: Minor
                Found in imports/collections/documentgeneration_private.js and 1 other location - About 50 mins to fix
                imports/collections/attachments_private.js on lines 103..106

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 51.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status