4minitz/4minitz

View on GitHub
imports/meetingseries.js

Summary

Maintainability
C
1 day
Test Coverage

MeetingSeries has 33 functions (exceeds 20 allowed). Consider refactoring.
Open

export class MeetingSeries {
    constructor(source) {   // constructs obj from Mongo ID or Mongo document
        if (! source)
            return;

Severity: Minor
Found in imports/meetingseries.js - About 4 hrs to fix

    File meetingseries.js has 257 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    import { Meteor } from 'meteor/meteor';
    import { Random } from 'meteor/random';
    import { MeetingSeriesSchema } from './collections/meetingseries.schema';
    import { MinutesFinder } from '/imports/services/minutesFinder';
    import { Minutes } from './minutes';
    Severity: Minor
    Found in imports/meetingseries.js - About 2 hrs to fix

      Function setVisibleAndInformedUsers has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          setVisibleAndInformedUsers(newVisibleForArray, newInformedUsersArray) {
              if (!this._id) {
                  throw new Meteor.Error('MeetingSeries not saved.', 'Call save() before using addVisibleUser()');
              }
              if (!$.isArray(newVisibleForArray)) {
      Severity: Minor
      Found in imports/meetingseries.js - About 1 hr to fix

        TODO found
        Open

                // TODO: refactor topic class and make this method obsolete
        Severity: Minor
        Found in imports/meetingseries.js by fixme

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            async updateLastMinutesFields (callback) {
                callback = callback || function () {};
        
                try {
                    let result = await this.updateLastMinutesFieldsAsync();
        Severity: Major
        Found in imports/meetingseries.js and 1 other location - About 1 hr to fix
        imports/infoitem.js on lines 134..143

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 70.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status