Sign upLogin

540co/ads-bpa

View on GitHub
Star
client/test/spec/services/reactions.js

Summary

Maintainability
D
1 day
Test Coverage

Similar blocks of code found in 9 locations. Consider refactoring.
Open

  describe('Method: Get Symptom Definition from Reactions API', function() {
    it('reactions.getSymptomDefinition() should be a function', function() {
      expect(angular.isFunction(reactions.reactions.getSymptomDefinition)).toBe(true);
    });
Severity: Major
Found in client/test/spec/services/reactions.js and 8 other locations - About 4 hrs to fix
client/test/spec/services/openFDA.js on lines 17..29
client/test/spec/services/openFDA.js on lines 31..43
client/test/spec/services/openFDA.js on lines 45..57
client/test/spec/services/openFDA.js on lines 59..71
client/test/spec/services/openFDA.js on lines 73..85
client/test/spec/services/openFDA.js on lines 87..99
client/test/spec/services/openFDA.js on lines 101..113
client/test/spec/services/openFDA.js on lines 115..127

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 134.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

  describe('Method: Post New Symptom Definition to Reactions API', function() {
    it('reactions.postNewDefinition() should be a function', function() {
      expect(angular.isFunction(reactions.reactions.postNewDefinition)).toBe(true);
    });
Severity: Major
Found in client/test/spec/services/reactions.js and 2 other locations - About 3 hrs to fix
client/test/spec/services/reactions.js on lines 31..39
client/test/spec/services/reactions.js on lines 51..59

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 96.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

  describe('Method: Post Symptom Definition to Reactions API', function() {
    it('reactions.postSymptomDefinition() should be a function', function() {
      expect(angular.isFunction(reactions.reactions.postSymptomDefinition)).toBe(true);
    });
Severity: Major
Found in client/test/spec/services/reactions.js and 2 other locations - About 3 hrs to fix
client/test/spec/services/reactions.js on lines 51..59
client/test/spec/services/reactions.js on lines 61..69

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 96.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

  describe('Method: Post Search Terms to Reactions API', function() {
    it('reactions.postSearchTerm() should be a function', function() {
      expect(angular.isFunction(reactions.reactions.postSearchTerm)).toBe(true);
    });
Severity: Major
Found in client/test/spec/services/reactions.js and 2 other locations - About 3 hrs to fix
client/test/spec/services/reactions.js on lines 31..39
client/test/spec/services/reactions.js on lines 61..69

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 96.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status