Sign upLogin

5v3n/tweetlr

View on GitHub
Star

Showing 4 of 4 total issues

Method process_link has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
Open

    def self.process_link(link, embedly_key)
      url = nil
      log.info "embedly processing the link..."
      url = image_url_embedly link, embedly_key
      if url.nil? #fallback to self written image extractors
Severity: Minor
Found in lib/tweetlr/processors/photo_service.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method post has 35 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def self.post(options={})
      log.info "posting to #{options['tumblr_blog_hostname'] || options['group']}..."
      base_hostname       = options['tumblr_blog_hostname'] || options['group']
      tumblr_oauth_api_key= options['tumblr_oauth_api_key'] 
      tumblr_oauth_api_secret= options['tumblr_oauth_api_secret']
Severity: Minor
Found in lib/tweetlr/processors/tumblr.rb - About 1 hr to fix

    Method http_get has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        def self.http_get(request)
      tries = 3
      curl = nil
      begin
        curl = Curl::Easy.new request
    Severity: Minor
    Found in lib/tweetlr/processors/http.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method post has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        def self.post(options={})
      log.info "posting to #{options['tumblr_blog_hostname'] || options['group']}..."
      base_hostname       = options['tumblr_blog_hostname'] || options['group']
      tumblr_oauth_api_key= options['tumblr_oauth_api_key'] 
      tumblr_oauth_api_secret= options['tumblr_oauth_api_secret']
    Severity: Minor
    Found in lib/tweetlr/processors/tumblr.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language