Sign upLogin

AASHE/python-membersuite-api-client

View on GitHub
Star

Showing 16 of 32 total issues

Function login_to_portal has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

def login_to_portal(username, password, client, retries=2, delay=0):
    """Log `username` into the MemberSuite Portal.

    Returns a PortalUser object if successful, raises
    LoginToPortalError if not.
Severity: Minor
Found in membersuite_api_client/security/services.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function get_long_query has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

    def get_long_query(self, base_object_query, limit_to=100, max_calls=None,
                       start_record=0, verbose=False):
        """
        Takes a base query for all objects and recursively requests them
Severity: Minor
Found in membersuite_api_client/mixins.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function submit_msql_object_query has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

def submit_msql_object_query(object_query, client=None):
    """Submit `object_query` to MemberSuite, returning
    .models.MemberSuiteObjects.

    So this is a converter from MSQL to .models.MemberSuiteObjects.
Severity: Minor
Found in membersuite_api_client/utils.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Consider simplifying this complex logical expression.
Open

        if self.address:
            self.street1 = self.address["Line1"] or ''
            self.street2 = self.address["Line2"] or ''
            self.city = self.address["City"] or ''
            self.state = self.address["State"] or ''
Severity: Critical
Found in membersuite_api_client/organizations/models.py - About 1 hr to fix

    Function get_stars_liaison_for_organization has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

        def get_stars_liaison_for_organization(self, organization):

        candidates = self.get_individuals_for_primary_organization(
            organization=organization)
    Severity: Minor
    Found in membersuite_api_client/organizations/services.py - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function get_subscriptions has 7 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def get_subscriptions(self, publication_id=None, owner_id=None,
    Severity: Major
    Found in membersuite_api_client/subscriptions/services.py - About 50 mins to fix

      Function get_all_memberships has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          def get_all_memberships(
      Severity: Minor
      Found in membersuite_api_client/memberships/services.py - About 45 mins to fix

        Function get_orgs has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            def get_orgs(
        Severity: Minor
        Found in membersuite_api_client/organizations/services.py - About 45 mins to fix

          Function run_object_query has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

          def run_object_query(client, base_object_query, start_record, limit_to,
          Severity: Minor
          Found in membersuite_api_client/mixins.py - About 35 mins to fix

            Function login_to_portal has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

            def login_to_portal(username, password, client, retries=2, delay=0):
            Severity: Minor
            Found in membersuite_api_client/security/services.py - About 35 mins to fix

              Function get_long_query has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                  def get_long_query(self, base_object_query, limit_to=100, max_calls=None,
              Severity: Minor
              Found in membersuite_api_client/mixins.py - About 35 mins to fix

                Function get_orgs has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                Open

                    def get_orgs(
            self, limit_to=100, max_calls=None, parameters=None,
            since_when=None, start_record=0, verbose=False):
        """
        Constructs request to MemberSuite to query organization objects.
                Severity: Minor
                Found in membersuite_api_client/organizations/services.py - About 35 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function phone_number has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                    def phone_number(self):
        numbers = self.fields["PhoneNumbers"]["MemberSuiteObject"]
        if len(numbers):
            for key_value_pair in (numbers[0]
                                   ["Fields"]["KeyValueOfstringanyType"]):
                Severity: Minor
                Found in membersuite_api_client/security/models.py - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function get_individuals_for_primary_organization has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                    def get_individuals_for_primary_organization(self,
                                                 organization):
        """
        Returns all Individuals that have `organization` as a primary org.
                Severity: Minor
                Found in membersuite_api_client/organizations/services.py - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function result_to_models has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                    def result_to_models(self, result):
        """
            this is the 'transorm' part of ETL:
            converts the result of the SQL to Models
        """
                Severity: Minor
                Found in membersuite_api_client/mixins.py - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function get_all_memberships has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                    def get_all_memberships(
            self, limit_to=100, max_calls=None, parameters=None,
            since_when=None, start_record=0, verbose=False):
        """
        Retrieve all memberships updated since "since_when"
                Severity: Minor
                Found in membersuite_api_client/memberships/services.py - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Severity
                Category
                Status
                Source
                Language