Sign upLogin

AD1024/SMS2Email

View on GitHub
Star

Showing 5 of 5 total issues

Method doInBackground has 61 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        @Override
        protected Void doInBackground(Void... voids) {
            Cursor cursor = null;
            Log.i("SMSService", "Handling new message");
            try {
Severity: Major
Found in app/src/main/java/ad1024/uw/sms2email/SMSObserver.java - About 2 hrs to fix

    Method onClick has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
    Open

        @Override
    public void onClick(View view) {
        if(view.getId() == R.id.btn_save_email) {
            String email = ed_email.getText().toString();
            if (!email.isEmpty()) {
    Severity: Minor
    Found in app/src/main/java/ad1024/uw/sms2email/MainActivity.java - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method doInBackground has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
    Open

            @Override
        protected Void doInBackground(Void... voids) {
            Cursor cursor = null;
            Log.i("SMSService", "Handling new message");
            try {
    Severity: Minor
    Found in app/src/main/java/ad1024/uw/sms2email/SMSObserver.java - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method onClick has 38 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        @Override
    public void onClick(View view) {
        if(view.getId() == R.id.btn_save_email) {
            String email = ed_email.getText().toString();
            if (!email.isEmpty()) {
    Severity: Minor
    Found in app/src/main/java/ad1024/uw/sms2email/MainActivity.java - About 1 hr to fix

      Method createNewEmail has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          public static MimeMessage createNewEmail(Session session, String from, String title,
                                             String content, String to) {
      Severity: Minor
      Found in app/src/main/java/ad1024/uw/sms2email/MailUtils.java - About 35 mins to fix
        Severity
        Category
        Status
        Source
        Language