Sign upLogin

APTrust/dart

View on GitHub
Star
bagit/bagger.js

Summary

Maintainability
B
6 hrs
Test Coverage

File bagger.js has 330 lines of code (exceeds 250 allowed). Consider refactoring.
Invalid

const { BagItFile } = require('./bagit_file');
const { Constants } = require('../core/constants');
const { Context } = require('../core/context');
const dateFormat = require('dateformat');
const EventEmitter = require('events');
Severity: Minor
Found in bagit/bagger.js - About 3 hrs to fix

    Function create has 38 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        async create() {
        var packOp = this.job.packageOp;
        this.emit('packageStart', `Starting to build ${packOp.packageName}`);
        packOp.result = new OperationResult('bagging', 'DART bagger');
        packOp.result.filepath = packOp.outputPath;
    Severity: Minor
    Found in bagit/bagger.js - About 1 hr to fix

      Function _setBagInfoAutoValues has 36 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          _setBagInfoAutoValues() {
        var profile = this.job.bagItProfile;
        var baggingDate = profile.firstMatchingTag('tagName', 'Bagging-Date');
        if (baggingDate) {
            baggingDate.userValue = dateFormat(Date.now(), 'isoUtcDateTime');
      Severity: Minor
      Found in bagit/bagger.js - About 1 hr to fix

        Function _writeManifests has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
        Open

            async _writeManifests(payloadOrTag) {
        var profile = this.job.bagItProfile;
        var manifestAlgs = profile.chooseManifestAlgorithms('manifest');
        var fileNamePrefix = 'manifest';
        if (payloadOrTag == 'tag') {
        Severity: Minor
        Found in bagit/bagger.js - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function _setBagInfoAutoValues has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
        Open

            _setBagInfoAutoValues() {
        var profile = this.job.bagItProfile;
        var baggingDate = profile.firstMatchingTag('tagName', 'Bagging-Date');
        if (baggingDate) {
            baggingDate.userValue = dateFormat(Date.now(), 'isoUtcDateTime');
        Severity: Minor
        Found in bagit/bagger.js - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function _writeManifests has 30 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            async _writeManifests(payloadOrTag) {
        var profile = this.job.bagItProfile;
        var manifestAlgs = profile.chooseManifestAlgorithms('manifest');
        var fileNamePrefix = 'manifest';
        if (payloadOrTag == 'tag') {
        Severity: Minor
        Found in bagit/bagger.js - About 1 hr to fix

          Identical blocks of code found in 2 locations. Consider refactoring.
          Invalid

                  let promise = new Promise(function(resolve, reject) {
            bagger.formatWriter.once('finish', function() {
                resolve();
            });
        });
          Severity: Minor
          Found in bagit/bagger.js and 1 other location - About 30 mins to fix
          bagit/bagger.js on lines 264..268

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 45.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Invalid

                  let promise = new Promise(function(resolve, reject) {
            bagger.formatWriter.once('finish', function() {
                resolve();
            });
        });
          Severity: Minor
          Found in bagit/bagger.js and 1 other location - About 30 mins to fix
          bagit/bagger.js on lines 248..252

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 45.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status