Sign upLogin

APTrust/dart

View on GitHub
Star
bagit/bagit_profile.js

Summary

Maintainability
B
4 hrs
Test Coverage

File bagit_profile.js has 327 lines of code (exceeds 250 allowed). Consider refactoring.
Invalid

const { AppSetting } = require('../core/app_setting');
const { BagItProfileInfo } = require('./bagit_profile_info');
const { Constants } = require('../core/constants');
const { Context } = require('../core/context');
const fs = require('fs');
Severity: Minor
Found in bagit/bagit_profile.js - About 3 hrs to fix

    BagItProfile has 29 functions (exceeds 20 allowed). Consider refactoring.
    Invalid

    class BagItProfile extends PersistentObject {

    constructor(opts = {}) {
        opts.required = ['name'];
        super(opts);
    Severity: Minor
    Found in bagit/bagit_profile.js - About 3 hrs to fix

      Function chooseManifestAlgorithms has 29 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          chooseManifestAlgorithms(whichType) {
        if (whichType != 'manifest' && whichType != 'tagmanifest') {
            throw Context.y18n.__("Param whichType must be either 'manifest' or 'tagmanifest'");
        }
        let required = this.manifestsRequired;
      Severity: Minor
      Found in bagit/bagit_profile.js - About 1 hr to fix

        Function _addStandardBagInfoFile has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Invalid

            _addStandardBagInfoFile() {
        var tags = [
            'Bag-Count',
            'Bag-Group-Identifier',
            'Bag-Size',
        Severity: Minor
        Found in bagit/bagit_profile.js - About 1 hr to fix

          Function chooseManifestAlgorithms has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
          Open

              chooseManifestAlgorithms(whichType) {
        if (whichType != 'manifest' && whichType != 'tagmanifest') {
            throw Context.y18n.__("Param whichType must be either 'manifest' or 'tagmanifest'");
        }
        let required = this.manifestsRequired;
          Severity: Minor
          Found in bagit/bagit_profile.js - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function validate has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

              validate() {
        this.errors = {};
        super.validate();
        if (Util.isEmptyStringArray(this.acceptBagItVersion)) {
            this.errors["acceptBagItVersion"] = Context.y18n.__("Profile must accept at least one BagIt version.");
          Severity: Minor
          Found in bagit/bagit_profile.js - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Avoid too many return statements within this function.
          Open

                  return [ allowed[0] ];
          Severity: Major
          Found in bagit/bagit_profile.js - About 30 mins to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    if (Util.isEmptyStringArray(this.manifestsAllowed)) {
            this.errors["manifestsAllowed"] = Context.y18n.__("Profile must allow at least one payload manifest algorithm.");
        }
            Severity: Minor
            Found in bagit/bagit_profile.js and 1 other location - About 35 mins to fix
            bagit/bagit_profile.js on lines 263..265

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 46.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    if (Util.isEmptyStringArray(this.acceptBagItVersion)) {
            this.errors["acceptBagItVersion"] = Context.y18n.__("Profile must accept at least one BagIt version.");
        }
            Severity: Minor
            Found in bagit/bagit_profile.js and 1 other location - About 35 mins to fix
            bagit/bagit_profile.js on lines 266..268

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 46.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status