APTrust/dart

View on GitHub
core/util.js

Summary

Maintainability
A
2 hrs
Test Coverage

File util.js has 362 lines of code (exceeds 250 allowed). Consider refactoring.
Invalid

const { Context } = require('./context');
const { fork } = require('child_process');
const fs = require('fs');
const path = require('path');
const os = require('os');
Severity: Minor
Found in core/util.js - About 4 hrs to fix

    Util has 36 functions (exceeds 20 allowed). Consider refactoring.
    Invalid

    class Util {
    
        /**
          * Returns a version 4 uuid string.
          *
    Severity: Minor
    Found in core/util.js - About 4 hrs to fix

      Function arrayContentsMatch has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          static arrayContentsMatch(a, b, orderMatters) {
              if (!Array.isArray(a) || !Array.isArray(b)) {
                  return false;
              }
              if (a === b) {
      Severity: Minor
      Found in core/util.js - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function deleteRecursive has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          static deleteRecursive(filepath) {
              if (filepath.length < 8 || filepath.split(path.sep).length < 3) {
                  throw `${filepath} does not look safe to delete`;
              }
              if (fs.existsSync(filepath)) {
      Severity: Minor
      Found in core/util.js - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function findCommonPathPrefix has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          static findCommonPathPrefix(paths, pathSep = path.sep) {
              let i = 0;
              let lastPrefix = '';
              let prefix = '';
              let match = true;
      Severity: Minor
      Found in core/util.js - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function unicodeByteLength has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Invalid

          static unicodeByteLength(str) {
              var s = str.length;
              for (var i=str.length-1; i>=0; i--) {
                  var code = str.charCodeAt(i);
                  if (code > 0x7f && code <= 0x7ff) s++;
      Severity: Minor
      Found in core/util.js - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this function.
      Open

              return true;
      Severity: Major
      Found in core/util.js - About 30 mins to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Invalid

            static canWrite(filepath) {
                let canWrite = true;
                try {
                    fs.accessSync(filepath, fs.constants.W_OK);
                } catch (err) {
        Severity: Major
        Found in core/util.js and 1 other location - About 1 hr to fix
        core/util.js on lines 585..593

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 64.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Invalid

            static canRead(filepath) {
                let canRead = true;
                try {
                    fs.accessSync(filepath, fs.constants.R_OK);
                } catch (err) {
        Severity: Major
        Found in core/util.js and 1 other location - About 1 hr to fix
        core/util.js on lines 602..610

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 64.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status