Sign upLogin

APTrust/dart

View on GitHub
Star
plugins/formats/read/tar_reader.js

Summary

Maintainability
B
5 hrs
Test Coverage

Function list has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    list() {
        var tarReader = this;
        var extract = tar.extract();
        tarReader.fileCount = 0;
        tarReader.dirCount = 0;
Severity: Minor
Found in plugins/formats/read/tar_reader.js - About 1 hr to fix

    Function read has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        read() {
        var tarReader = this;
        var extract = tar.extract();
        tarReader.fileCount = 0;
        tarReader.dirCount = 0;
    Severity: Minor
    Found in plugins/formats/read/tar_reader.js - About 1 hr to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Invalid

          constructor(pathToTarFile) {
        super();
        /**
         * pathToTarFile is the absolute path to the tar file that
         * this iterator will read.
      Severity: Major
      Found in plugins/formats/read/tar_reader.js and 1 other location - About 2 hrs to fix
      plugins/formats/read/file_system_reader.js on lines 39..70

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 79.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

                      if (header.type === "file") {
                    tarReader.fileCount += 1;
                    tarReader.byteCount += Number(fileStat.size);
                } else if (header.type === "directory") {
                    tarReader.dirCount += 1;
      Severity: Major
      Found in plugins/formats/read/tar_reader.js and 1 other location - About 1 hr to fix
      plugins/formats/read/tar_reader.js on lines 204..209

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 72.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

                      if (header.type === "file") {
                    tarReader.fileCount += 1;
                    tarReader.byteCount += Number(fileStat.size);
                } else if (header.type === "directory") {
                    tarReader.dirCount += 1;
      Severity: Major
      Found in plugins/formats/read/tar_reader.js and 1 other location - About 1 hr to fix
      plugins/formats/read/tar_reader.js on lines 134..139

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 72.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Invalid

          static description() {
        return {
            id: 'd1045d20-153b-478c-aca4-7192c4ce624f',
            name: 'TarReader',
            description: 'Built-in DART tar reader',
      Severity: Major
      Found in plugins/formats/read/tar_reader.js and 1 other location - About 1 hr to fix
      plugins/formats/read/file_system_reader.js on lines 77..89

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 67.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status