Sign upLogin

APTrust/dart

View on GitHub
Star
plugins/formats/write/tar_writer.js

Summary

Maintainability
C
7 hrs
Test Coverage

Function add has 35 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    add(bagItFile, cryptoHashes = []) {
        super.add(bagItFile, cryptoHashes);
        var tarWriter = this;
        var header = {
            // Don't use path.join because Windows will give us
Severity: Minor
Found in plugins/formats/write/tar_writer.js - About 1 hr to fix

    Function _mkdir has 33 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        _mkdir(bagItFile) {
        var tarWriter = this;
        var header = {
            name: bagItFile.relDestPath,
            type: 'directory',
    Severity: Minor
    Found in plugins/formats/write/tar_writer.js - About 1 hr to fix

      Function writeFile has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function writeFile(data, done) {
    try {
        var reader = fs.createReadStream(data.bagItFile.absSourcePath);

        reader.on('error', function(err) {
      Severity: Minor
      Found in plugins/formats/write/tar_writer.js - About 1 hr to fix

        Function _ensureDirectories has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            _ensureDirectories(fileHeader) {
        let template =
        {
            relDestPath: '',
            mode: 0o755,
        Severity: Minor
        Found in plugins/formats/write/tar_writer.js - About 1 hr to fix

          Function _ensureDirectories has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

              _ensureDirectories(fileHeader) {
        let template =
        {
            relDestPath: '',
            mode: 0o755,
          Severity: Minor
          Found in plugins/formats/write/tar_writer.js - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function _getTarOutputWriter has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

              _getTarOutputWriter() {
        if (this._tarOutputWriter == null) {
            if (!this.pathToTarFile.endsWith(".tar")) {
                throw new Error(Context.y18n.__(`pathToTarFile '%s' must have .tar extension`, this.pathToTarFile));
            }
          Severity: Minor
          Found in plugins/formats/write/tar_writer.js - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Invalid

              static description() {
        return {
            id: '90110710-1ff9-4650-a086-d7b23772238f',
            name: 'TarWriter',
            description: 'Built-in DART tar writer. Writes files directory into a tarball.',
          Severity: Major
          Found in plugins/formats/write/tar_writer.js and 1 other location - About 1 hr to fix
          plugins/formats/write/file_system_writer.js on lines 36..48

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 67.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

              try {
        var reader = fs.createReadStream(data.bagItFile.absSourcePath);

        reader.on('error', function(err) {
            data.errFn(err);
          Severity: Major
          Found in plugins/formats/write/tar_writer.js and 1 other location - About 1 hr to fix
          plugins/formats/write/file_system_writer.js on lines 119..126

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 61.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status